1035823 - [DSDS] The SIM manager page is not refreshed if configuration changes

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Julien Wajsberg [:julienw]]

STR:
Prerequisite: have a DSDS phone with enough RAM (Dolphin works fine, not Tarako) and with 2 SIMs: SIM1 and SIM2

1. open the Settings app
2. open SIM Manager
3. set all configuration to SIM1
4. from another device, send a MMS to SIM2
5. from DuT, wait MMS arrives, tap the notification
6. tap "download"
7. tap "OK" when the dialog asks to change the SIM
8. press home, open Settings again 
=> it should not have been killed, so the same panel is opened

Expected:
* we should see "SIM2" for the "data" configuration

Actual
* we see that the panel still reads SIM1 in the "data" section

Requesting 2.0? blocker status. It's not really a regression (the issue was probably here in 1.3t already) but it was not an issue on Tarako because the memory pressure would kill the settings app. This is now an issue with devices that have more RAM.

Moreover it should be really easy to fix.

Comment 1

[bhavana bajaj [:bajaj]]

Julien, can you please help to understand if you are able to reproduce this on flame and dolphin ? and also what is the build id you are using ?

Comment 2

[Julien Wajsberg [:julienw]]

I was using Dolphin, but I flashed it with a v1.4 build since then so I don't have the previous buildid anymore.

Haven't tried on Flame but I'm confident the issue is there too.

IMO it should block whatever release will be used on a DSDS phone with at least 256MB of RAM. Maybe request qawanted if you want to test on different devices and branches?

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master

Arthur I just made the patch for this bug, please give it a try when you have time ! Thanks.

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8455154 [details] [review]
patch on master

Thanks for proposing the patch so quickly. Please check my comments in github, thanks.

Comment 5

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8455154 [details] [review]
patch on master

Arthur, just addressed all your comments, please give a check ! Thanks :)

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8455154 [details] [review]
patch on master

r=me, thank you!

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Merged into 

Gaia/master : e411b11f085cb895e6a5cf3b494fba236e65ee48
Gaia/v2.0 : b0ef6563d8dbd29f49bc11f8a7960e0e78e50637

Thanks all.

Comment 8

[Wei Gao (Spreadtrum)]

[Blocking Requested - why for this release]:

Comment 9

[Wayne Chang [:wchang]]

Hi EJ,

Can you see if this fix is suitable for 1.4 and required? if so please send a 1.4?approval to :preeti

Thank you,
Wayne

Comment 10

[Bruce Huang [:bhuang] (inactive)]

I recommend we include for 1.4 as well since data settings on SIM may lead to customer care calls if not correctly reflected.

Comment 11

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

I think this patch is ok for 1.4 and not risky, so let me ask for approval.

Comment 12

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8455154 [details] [review]
patch on master

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: users may get confused if they changed defaultId to receive mms while settings app was open, the UI would not be consistent with real situation.
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): low because this happens rarely.
[String changes made]: no

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/ce631d7ada1845ef7ed925a506eb91cda6f09d24

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to revert this from 1.4 for Gu test failures: https://tbpl.mozilla.org/php/getParsedLog.php?id=46308580&tree=Mozilla-B2g30-v1.4

https://github.com/mozilla-b2g/gaia/commit/c63ba42425986371adf3eff74744c0e017734456

Comment 15

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on v1.4

This is the same patch taken from merged patch in master and fixed a test bug.

Comment 16

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Everything looks nice and merged into Gaia/v1.4 : https://github.com/mozilla-b2g/gaia/commit/14cb1ccc34ea99bf191c0b04d1531556d26a3a12

Comment 17

[Shine(Leave from Mozilla)]

Attachment: video

This issue has been verified successfully on Flame 2.0 and 2.1
See attachment: Verify_1035823.MP4
Reproducing rate: 0/3

Flame 2.0 build:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/29222e215db8
Build-ID        20141203000201
Version         32.0

Flame 2.1 build:
Gaia-Rev        dbaf3e31c9ba9c3436e074381744f2971e15c7bf
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/ebce587d2194
Build-ID        20141203001205
Version         34.0