1035978 - Layers/displaylist dumps don't print newline

Status: RESOLVED FIXED

Description

[Benoit Girard (:BenWa)]

Created attachment 8452490 [details] [diff] [review]
patch

+++ This bug was initially created as a clone of Bug #1030245 +++

Looks like adb logcat will implicitly add a new line if it's missing from the end but this doesn't happen on the desktop or the profiler.

Comment 1

[Benoit Girard (:BenWa)]

CCing 21 since he hit this bug.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8452490 [details] [diff] [review]
patch

Review of attachment 8452490 [details] [diff] [review]:
-----------------------------------------------------------------

This feels too clunky to me. If getline() doesn't tack on the \n then we should just do that in the printf_stderr call. It sounded like the problem then is that we get a blank line at the end of the dump, which we should be able to strip out like so:

     while (!ss.eof()) {
       ss.getline(line, sizeof(line));
-      printf_stderr("%s", line);
+      if (!ss.eof() || strlen(line) > 0) {
+        printf_stderr("%s\n", line);
+      }
       if (ss.fail()) {
         // line was too long, skip to next newline
         ss.clear();
         ss.ignore(std::numeric_limits<std::streamsize>::max(), '\n');
       }
     }

Comment 3

[Benoit Girard (:BenWa)]

Created attachment 8452590 [details] [diff] [review]
patch

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8452590 [details] [diff] [review]
patch

Review of attachment 8452590 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with thing below fixed

::: layout/base/nsLayoutUtils.cpp
@@ +3001,5 @@
>      while (!ss.eof()) {
>        ss.getline(line, sizeof(line));
> +      if (!ss.eof() || strlen(line) > 0) {
> +        printf_stderr("%s\n", line);
> +      }

Presumably you want to keep the fprintf_stderr(gfxUtils::sDumpPaintFile...

Comment 5

[Benoit Girard (:BenWa)]

Created attachment 8452616 [details] [diff] [review]
patch v2

fixed

Comment 6

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e7a2beb507f5

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e7a2beb507f5