Closed Bug 1036016 Opened 10 years ago Closed 10 years ago

"puzzle-piece" add-on icon in location bar doesn't go away after installing an add-on from 3rd-party site (until you click it to see why it's still there)

Categories

(Firefox :: Address Bar, defect)

13 Branch
x86_64
All
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 758822

People

(Reporter: dholbert, Unassigned)

References

Details

(Keywords: regression, ux-consistency)

Attachments

(2 files)

STR:
 1. Visit https://www.eff.org/privacybadger
 2. Click green "Install" button
 3. Click "Allow", and then "Install Now"
     --> A doorhanger appears letting you know that the
         extension has been installed successfully.
 4. Click a blank spot on the web page to dismiss the doorhanger.

EXPECTED RESULTS: The puzzle-piece icon in the URLbar should go away when the "installed successfully" doorhanger is dismissed.

ACTUAL RESULTS: The icon remains at the left end of the URLbar. If you click it (to see what it's still doing there), *then* it disappears.


If I repeat the STR with a restartless add-on from AMO, e.g.:
 https://addons.mozilla.org/en-US/firefox/addon/flagfox/
then I get EXPECTED RESULTS.  But Privacy Badger gives me ACTUAL RESULTS, which I'm guessing is related to it being from a 3rd-party site.
(If you've never installed Privacy Badger before, you'll get a "welcome" page between steps 3 and 4. Just dismiss that page and switch back to the tab where you installed Privacy Badger from.)
Attached video screencast
Here's a screencast.

This time, there was actually a brief flash of a doorhanger that I caught on film, when I clicked the puzzle-piece to dismiss it -- it's an "Add-on downloading" progress-bar, which flashes and then immediately disappears.  (This makes no sense to display, because the add-on has already downloaded & installed.)
(This screencast was the only time I saw the bogus doorhanger-flash, when clicking the icon -- I'm not sure if that's related to the straggling icon or not.)
Ubuntu 14.04
Version info: 33.0a1 (2014-07-08)
Mozilla/5.0 (X11; Linux x86_64; rv:33.0) Gecko/20100101 Firefox/33.0
Blair, do you know what's up here?
Component: General → Location Bar
Flags: needinfo?(bmcbride)
No idea :\ I can't think of anything that changed that would affect this (the only patch I had in mind hasn't landed yet).

Would be best to get a regression window for this, IMO.
Flags: needinfo?(bmcbride)
Not a recent regression -- I can reproduce this at least as far back as Nightly 22.0a1 (2013-03-15)
UA string: Mozilla/5.0 (X11; Linux x86_64; rv:22.0) Gecko/20130315 Firefox/22.0

I also tried my next-older build, which is Nightly v20 build from 2013-01-01, but the STR can't be performed there, because PrivacyBadger says it's incompatible. (too old)  I'm guessing this bug has been around since before then, though (since it affects a build from just a few months after it), so if we actually want to track down a regression window for this, we'll need functioning STR with a different addon that works in older versions (and is hosted on a 3rd-party site).

Alternately, this might not really be a regression (or might be old enough that it doesn't matter that it's a regression).
Marking this backlog+ because having non-functional buttons in our UI kind of sucks.
Flags: firefox-backlog+
Keywords: ux-consistency
Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/28ebf87f14a9
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120418 Firefox/14.0a1 ID:20120418010640
Bad:
http://hg.mozilla.org/mozilla-central/rev/f9fbee492a5c
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120418 Firefox/14.0a1 ID:20120418100418
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=28ebf87f14a9&tochange=f9fbee492a5c

Regressed by:
218a9ef79151	Olli Pettay — Bug 745744 - Geolocation doorhanger might cause zombie compartments because it keeps callbacks alive, r=gavin, a=desktop-only
Blocks: 745744
OS: Linux → All
Version: Trunk → 13 Branch
Thanks, Alice0775!

Given that, it looks like this is actually a dupe of bug 758822, which I filed 2 years ago and have since forgotten about. (Slightly different STR, but basically the same symptom.)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Flags: firefox-backlog+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: