Closed
Bug 1036022
Opened 12 years ago
Closed 12 years ago
Links broken under "Make" section of Webmaker.org/resources
Categories
(Webmaker Graveyard :: webmaker.org, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kat, Assigned: akirose)
References
Details
Attachments
(2 files)
Was just about to update JSON on the https://webmaker.org/resources Web Literacies pages when I realised that due to new syntax and other recent pushes, it looks like the "Make" sections are broken.
See attachment for screenshot of Coding/Scripting page as example. Each of those listed links don't link to anything, because they're meant to be titles, with the descriptions *also* showing which have links embedded.
The descriptions look like they're still in the JSON, just not showing in the front-end.
Also: Plz let me know when this is fixed how you'd like the syntax to work for future "Make" sections, as I have a lot of em to update :)
| Reporter | ||
Updated•12 years ago
|
Assignee: nobody → aki
| Assignee | ||
Comment 1•12 years ago
|
||
Attachment #8452641 -
Flags: review?(kate)
Comment 3•12 years ago
|
||
Comment on attachment 8452641 [details] [review]
https://github.com/mozilla/webmaker.org/pull/854
Looks good, one small suggestion feel free to ignore if it doesn't make sense
Attachment #8452641 -
Flags: review?(kate) → review+
Comment 4•12 years ago
|
||
Commits pushed to master at https://github.com/mozilla/webmaker.org
https://github.com/mozilla/webmaker.org/commit/6627cd27eb293ccec7321c7fca16ac68ffa5af79
Fixes Bug 1036022 - Links broken under "Make" section of Webmaker.org/resources
https://github.com/mozilla/webmaker.org/commit/290edb5599764e77f3a636791cb30e9d3c1dadb4
Merge pull request #854 from gesa/1036022/resources-content
Fixes Bug 1036022 - Links broken under "Make" section of Webmaker.org/resources
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
| Assignee | ||
Comment 5•12 years ago
|
||
@codekat: this is up on staging, ready to head to prod https://webmaker.mofostaging.net/resources/literacy/weblit-Navigation
| Assignee | ||
Comment 6•12 years ago
|
||
And now it's on its way to production, should be there in 5 min or so.
| Reporter | ||
Updated•12 years ago
|
| Reporter | ||
Comment 7•12 years ago
|
||
:BenB Ah, fail, have fixed ;)
Aki: YAY! YOU RULE.
You need to log in
before you can comment on or make changes to this bug.
Description
•