1036037 - jsapi-tests for JIT optimizations

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Description

[Dan Gohman [:sunfish]]

Attachment: div-reciprocal-test.patch

While reviewing bug 999764, a way to write unit tests for JIT optimizations was missed. Inspired by js/src/jsapi-tests/testJitRValueAlloc.cpp, it seems we now have a way to add jsapi-tests tests that test JIT features.

Attached is a patch which adds a testcase that tests the feature added in bug 999764. I'm unsure if this is a good approach, but it seems to work.

Comment 1

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8452596 [details] [diff] [review]
div-reciprocal-test.patch

Review of attachment 8452596 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsapi-tests/testJitFoldsTo.cpp
@@ +19,5 @@
> +
> +struct MinimalFunc
> +{
> +    LifoAlloc lifo;
> +    TempAllocator alloc;

Nice :)

Might be worth adding to a new jsapi-tests header dedicated to making Ion tests.

Comment 2

[Dan Gohman [:sunfish]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a61e96de3acb

A jsapi-tests header for Ion tests is a good idea. We can do that when we add more tests :).

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a61e96de3acb