1036104 - Partner repack changes for web.de, gmx, mail.com and 1&1 (Firefox 31)

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, defect)

Description

[Mike Kaply [:mkaply]]

Patch coming in a few minutes. Sorry for the lateness on this. Our build just got approved by QA.

Comment 1

[Mike Kaply [:mkaply]]

We have switched to using a chrome JAR file and unpacking our extensions, primarily because we need to be able to use the searchplugins directory properly.

So I'll be removing a lot of files and checking in a chrome.jar. I already checked and other extensions like yandex use a JAR file, so this doesn't seem to be an issue.

I'll be attaching separate diffs for the actual toolbar. This diff will be a diff of our entire source tree (which is used as the basis for all three toolbars), so it should be much easier to review.

Please let me know if you see any issues with this.

Comment 2

[Mike Kaply [:mkaply]]

Question:

Is it possible to use the try server to do a partner repack builds?

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Overview of changes

Comment 4

[Mike Kaply [:mkaply]]

Attachment: Patches by commit

This contains each individual patch as a commit.

Comment 5

[Mike Kaply [:mkaply]]

Attachment: Complete diff

This contains the complete diff.

Most of these changes are cosmetic including:

Changing lets to var and for each to forEach (for better Chrome merging).
Changing debug to ddebug.
Removal of coupon extension.

Comment 6

[Mike Kaply [:mkaply]]

Attachment: HG diff (mainly removal of files)

Huge diff because it's mostly removed files.

Comment 7

[Mike Kaply [:mkaply]]

Attachment: 1und1 changes

We are also officially adding a 1und1 browser toolbar with this release.

Here is the diff for that. The source code comes from the same tree as the overall diff.

Comment 8

[Mike Kaply [:mkaply]]

Is there any chance this can get reviewed? We're just about out of runway for Firefox 31.

Again, my apologies for the delay.

Comment 9

[Mike Connor [:mconnor]]

Comment on attachment 8452858 [details] [diff] [review]
Complete diff

This looks okay, but I really don't understand why all of the let usage was changed to var... over-eager mechanical changes?

Comment 10

[Mike Kaply [:mkaply]]

(In reply to Mike Connor [:mconnor] from comment #9)
> Comment on attachment 8452858 [details] [diff] [review]
> Complete diff
> 
> This looks okay, but I really don't understand why all of the let usage was
> changed to var... over-eager mechanical changes?

We share our code between Chrome and Safari, so we wanted it to be able to be merged.

Same with the for each code.

Comment 11

[Mike Kaply [:mkaply]]

https://hg.mozilla.org/build/partner-repacks/rev/e95fed5e3a46

Comment 12

[Mike Connor [:mconnor]]

Builds from build2 should have these changes, according to tags.