1036131 - [B2G][2.0][Contacts] The change of position for the icons on the contact details page causes overlap in many languages.

Status: RESOLVED DUPLICATE of bug 1036147

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Attachment: wall post.png

Description:
When a contact has an associated facebook profile, the text for the 'Wall post' and 'View Facebook profile' buttons will overlap the icons for many languages

Prerequisites:
1) Settings > Language > Portuguese (Brazil) (pt-BR)
2) Have a linked Facebook account in the conact app

Repro Steps:
1) Update a Flame to 20140707000200
2) Open the Contacts app
3) Open a contact with a linked Facebook profile
4) Note the Wall post button
5) Go to Settings > Language > and change to Polish
6) Return to the contact in step 3
7) Note the View Facebook profile button

Actual:
Text is overlapped in multiple languages. because of the change of icon position.

Expected:
The text does not overlap with the ui.

Environmental Variables:
Device: Flame 2.0
BuildID: 20140707000200
Gaia: ef67af27dff3130d41a9139d6ae7ed640c34d922
Gecko: f53099796238
Version: 32.0a2 (2.0) 
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0


Repro frequency: 100%
Link to failed test case:https://moztrap.mozilla.org/manage/case/12798/
See attached: screenshot

Comment 1

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Attachment: view profile.png

Comment 2

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This does NOT occur on 1.4 Flame.

Environmental Variables:
Device: Flame 1.4
Build ID: 20140707000200
Gaia: 5c9e1e4131d3ac8915ed88b72bb66dc7d97be6a0
Gecko: 2d0c15450488
Version: 30.0 (1.4) 
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

The icons were all on the left side of the text boxes and were not overlapped by the text.



This issue DOES occur on 2.1 Flame and 2.0 Buri.

Environmental Variables:
Device: Flame Master
BuildID: 20140707040201
Gaia: 93daa354671a698634a3dc661c8c9dcb7d824c31
Gecko: 1dc6b294800d
Version: 33.0a1 (Master) 
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Environmental Variables:
Device: Buri 2.0
BuildID: 20140707000200
Gaia: ef67af27dff3130d41a9139d6ae7ed640c34d922
Gecko: f53099796238
Version: 32.0a2 (2.0) 
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0


The text is overlapped by the icons and the icons are on the right side instead of the left.

Comment 8

[Jason Smith [:jsmith]]

This is missing a blocking triage analysis.

Comment 9

[KTucker [:KTucker][Inactive 3/4/2016]]

This is a regression from 1.4. The text should be truncated when too long or wrap the text to the next line. This will look bad to the end user and is not something people would expect from a polished product. Since this is affecting multiple languages, I would suggest we nominate 2.0?

Comment 10

[Jose Manuel Cantera]

After some investigations with Arnau, We have determined that this bug depends on an already reported platform bug. So, removing myself from assignee

Comment 11

[Joshua Mitchell (Inactive)]

(In reply to Jose Manuel Cantera from comment #10)
> After some investigations with Arnau, We have determined that this bug
> depends on an already reported platform bug. So, removing myself from
> assignee

Would it be safe to remove regression-window-wanted from this as it seems the cause has already been identified?

Comment 12

[Jason Smith [:jsmith]]

(In reply to Joshua Mitchell [:Joshua_M] from comment #11)
> (In reply to Jose Manuel Cantera from comment #10)
> > After some investigations with Arnau, We have determined that this bug
> > depends on an already reported platform bug. So, removing myself from
> > assignee
> 
> Would it be safe to remove regression-window-wanted from this as it seems
> the cause has already been identified?

Yes.

Comment 13

[Francisco Jordano [:arcturus] [:francisco]]

Keeping open till we take a look once bug 1010675 is fixed.

Comment 14

[Kai-Chih Hu [:khu]]

Wesley, is it something that Comms team can help? Thanks.

Comment 15

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

The discussion of platform bug (bug 1010675) is still going on. 
To be more practical, should we consider workaround from contact app?
This isn't perfect but there's a FC date we need to catch up.

Comment 16

[Jose Manuel Cantera]

(In reply to Wesley Huang [:wesley_huang] from comment #15)
> The discussion of platform bug (bug 1010675) is still going on. 
> To be more practical, should we consider workaround from contact app?
> This isn't perfect but there's a FC date we need to catch up.

I would not recommend that as the platform bug is affecting other apps, for instance, settings.

Comment 17

[Kai-Chih Hu [:khu]]

David, I was told that we can only provide workaround before 7/21. Can you accept that? Thanks.

Comment 18

[Francisco Jordano [:arcturus] [:francisco]]

We will need to perform several workarounds, are we sure we cannot make it in platform for the end of the sprint?

Comment 19

[David Scravaglieri [:scravag]]

Kevin, I don't think this is acceptable, multiple apps will have to find a workaround, this doesn't scale

Comment 20

[Kai-Chih Hu [:khu]]

Thanks, David. 

I agreed with you. Since you're the component owner, we still need to confirm with you to get your feedback. But, in this case, we are clear that, we can't resolve this bug before 7/21, right? I am thinking to move this to 2.1, but this is a regression bug... What's your take here?

Comment 21

[Jason Smith [:jsmith]]

(In reply to Kevin Hu [:khu] from comment #20)
> Thanks, David. 
> 
> I agreed with you. Since you're the component owner, we still need to
> confirm with you to get your feedback. But, in this case, we are clear that,
> we can't resolve this bug before 7/21, right? I am thinking to move this to
> 2.1, but this is a regression bug... What's your take here?

We really should avoid kicking this bug out - we'll run into trouble in certification if we keep this bug in the product, as there's truncation issues present in multiple shipping locales that localizers cannot workaround.

Comment 22

[howie [:howie]]

Just FYI, David Baron's suggestion: https://bugzilla.mozilla.org/show_bug.cgi?id=1010675#c85

Comment 23

[Kai-Chih Hu [:khu]]

(In reply to howie [:howie] from comment #22)
> Just FYI, David Baron's suggestion:
> https://bugzilla.mozilla.org/show_bug.cgi?id=1010675#c85

Looks like David Baron is asking for a workaround from Gaia side? In this case, David S. and David B., can you two come out an agreement about the bug? Or, what's all your suggestions on these bugs? Thanks.

Comment 24

[Francisco Jordano [:arcturus] [:francisco]]

Workaround is provided in bug 1036147

Comment 25

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Sounds like there's already a workaround patch.

Comment 26

[David Scravaglieri [:scravag]]

clear n?