bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Allow users to manage which login services are associated with their account

RESOLVED FIXED

Status

developer.mozilla.org
Sign-in
--
enhancement
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: openjck, Assigned: jezdez)

Tracking

(Blocks: 1 bug)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
It has been proposed that the profile page (or profile edit page, or both) link to a page where a user will be able to manage the login services that are associated with the MDN account.

For example, a user could use this tool to add GitHub as a login option if only Persona has been associated already (and vice-versa). A user could also use this tool to dis-associate either GitHub or Persona from their MDN account (but not both).

Does this sound correct? I don't see it mentioned in the PDF. Jannis mentioned talking to Holly about it this morning.
Flags: needinfo?(hhabstritt.bugzilla)
(Reporter)

Comment 1

4 years ago
Quoting Maris from the Trello board:

> As a User, I would like to change the GitHub account that I have linked to my
> MDN profile, in case I have more than one GitHub account.
(Reporter)

Comment 2

4 years ago
Quoting another card from the Trello board:

> As a User, I would like to remove the link between my MDN profile and my
> GitHub account.

Updated

4 years ago
Severity: normal → enhancement
(Reporter)

Comment 3

4 years ago
Note from Jannis:

django-allauth provides a view for this kind of thing. Might be a good starting point for discussions about UI.
Created attachment 8456973 [details]
profilelinks_140703.jpg

Mockup for indicating which accounts are connected for sign in purposes, how, and with links to disconnect on the user's profile.
Flags: needinfo?(hhabstritt.bugzilla)
In case it is not clear from the mockup, these are additions to the "Other Profiles" section of the existing profile edit page.
(Assignee)

Comment 6

4 years ago
To answer some questions from the technical side of things and ask back:

1. Yes, users could disconnect Persona if there is another account (Github or Persona) hooked up.
2. The profile doesn't allow currently to store boolean information whether a certain connected account should be shown on the profile. That would need to be added to the profile data model for each possible account system (Persona and Github currently). This is easy, but still needs backend work.
3. The "change" link next to the Persona account needs clarification. Should that be a "Add a new persona account and disconnect the old one?" Or just "add another Perona account"? The first requires extra backend work, the latter does not (but may need showing a *list* of Persona accounts in the profile edit form).
(In reply to Jannis Leidel [:jezdez] from comment #6)
> To answer some questions from the technical side of things and ask back:
>
> 2. The profile doesn't allow currently to store boolean information whether
> a certain connected account should be shown on the profile. That would need
> to be added to the profile data model for each possible account system
> (Persona and Github currently). This is easy, but still needs backend work.

This is not critical for launch. Until the checkbox exists we can just assume if they have connected the account we can display it on their profile.

> 3. The "change" link next to the Persona account needs clarification. Should
> that be a "Add a new persona account and disconnect the old one?" Or just
> "add another Perona account"? The first requires extra backend work, the
> latter does not (but may need showing a *list* of Persona accounts in the
> profile edit form).

The "change" link should do exactly what the "change" link next to the email address does right now. 

The "change" link next to the email address will change to letting the user change the email address they get notifications emailed to.
(Reporter)

Comment 8

4 years ago
I love this. Simple, straightforward, clear. Nice work, Stephanie!

And thanks for sharing the information about back-end implementation, Jannis! That will be a big help.

I wonder if some users will request that the login account and the display account be de-coupled, allowing them to list an account on their profile that is different from the one they logged in with. I doubt many people will want this, though, and even then am not convinced that we will really need to worry about that use case. If nothing else, we might want to be prepared to WONTFIX this idea.
(Reporter)

Updated

4 years ago
Blocks: 1042283
(Reporter)

Comment 9

4 years ago
(In reply to Stephanie Hobson [:shobson] from comment #7)
> (In reply to Jannis Leidel [:jezdez] from comment #6)
> > To answer some questions from the technical side of things and ask back:
> >
> > 2. The profile doesn't allow currently to store boolean information whether
> > a certain connected account should be shown on the profile. That would need
> > to be added to the profile data model for each possible account system
> > (Persona and Github currently). This is easy, but still needs backend work.
> 
> This is not critical for launch. Until the checkbox exists we can just
> assume if they have connected the account we can display it on their profile.

I opened bug 1042283 for this particular feature. Let's keep it on our radars, but finish the critical functionality first.
(Assignee)

Updated

4 years ago
Assignee: nobody → jezdez
(Assignee)

Comment 10

4 years ago
This is now implemented in https://github.com/mozilla/kuma/pull/2552

Comment 11

4 years ago
Commit pushed to persona-allauth at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/f4e8bf88189d63210ce49d05619ea9716f9c9590
Allow users to manage social accounts from profile view. Fixes bug 1036134.

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Comment 12

4 years ago
Commit pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/f4e8bf88189d63210ce49d05619ea9716f9c9590
Allow users to manage social accounts from profile view. Fixes bug 1036134.
You need to log in before you can comment on or make changes to this bug.