If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Users can't add Expertise to their profiles

RESOLVED FIXED

Status

Mozilla Developer Network
Profiles
--
major
RESOLVED FIXED
3 years ago
a year ago

People

(Reporter: shobson, Unassigned)

Tracking

({ux-consistency})

Details

(Whiteboard: [specification][type:bug][LOE:5])

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
What did you do?
================
1. Logged in
2. Added interests to my profile
3. Saved page
4. Tried to declare myself an expert but couldn't.

What happened?
==============
The tag widget for adding interests functions differently than the tag widget for adding tags to pages.

I am not able to declare myself an expert.

What should have happened?
==========================
I expected the tag widget to be the same tag widget as editing pages.

I expected that after adding interests I would be able to declare myself an expert in some of them based on the copy on the page.

Is there anything else we should know?
======================================
Might be an opportunity to shrink our code base and increase performance here :)
(Reporter)

Comment 1

3 years ago
Created attachment 8452752 [details]
Screen Shot 2014-07-08 at 16.24.12.png

There are interests listed but the text around expertise still says I have to add some.
I couldn't figure out how to add Expertise either.  If it is possible, I couldn't figure out how to do it without spending a lot more effort than it took me to add Interests, which means Expertise is effectively broken.  Triaging as Major to reflect that.
Severity: normal → major
Component: General → User profiles
Keywords: ux-consistency
Summary: Problems with Interests and expertise → Users can't add Expertise to their profiles
The areas of expertise appear to only be valid from our list of specific areas:

```
["audio","canvas","css3","device","files","fonts","forms","geolocation","javascript","html5","indexeddb","dragndrop","mobile","offlinesupport","svg","video","webgl","websockets","webworkers","xhr","multitouch","front-end development","web development","tech writing","user experience","design","technical review","editorial review"]
```

We'll need to find a good way to present that to the user, or simply show all checkboxes regardless of interests box, or ...?  Let's figure out what we want, then we can re-code.
(Reporter)

Comment 4

3 years ago
I tried adding CSS3 as an interest and was not given the option to add it as an expertise, so I'm not even sure that much is working?

I suspect it is not a priority to spec and recode this and because it is a feature that appears broken and is in production I am tempted to just remove it.

I think we need direction here. :hoosteeno. Rework, remove, or...?
Flags: needinfo?(hoosteeno)
(Reporter)

Comment 5

3 years ago
(In reply to Stephanie Hobson [:shobson] from comment #4)
> I tried adding CSS3 as an interest and was not given the option to add it as
> an expertise, so I'm not even sure that much is working?

Worked for me on my second try but still not intuitive.
Created attachment 8460579 [details]
interests_expertise_broken.swf



> I suspect it is not a priority to spec and recode this and because it is a
> feature that appears broken and is in production I am tempted to just remove
> it.

It does seem broken. I can't save interests and expertise at all. Attaching a screenshot for posterity. At this point both interests AND expertise seem broken to me. 

:groovecoder, what percentage of people have filled out these fields?
Flags: needinfo?(hoosteeno) → needinfo?(lcrouch)
Looks like 8065 users have created 38,250 profile tags:

    mysql> select count(distinct tagged_item.object_id) from taggit_tag tag, taggit_taggeditem tagged_item where tag.slug like 'profile%' and tagged_item.tag_id = tag.id;
    +---------------------------------------+
    | count(distinct tagged_item.object_id) |
    +---------------------------------------+
    |                                  8065 |
    +---------------------------------------+
    1 row in set (0.15 sec)
     
    mysql> select count(tagged_item.id) from taggit_tag tag, taggit_taggeditem tagged_item where tag.slug like 'profile%' and tagged_item.tag_id = tag.id;
    +-----------------------+
    | count(tagged_item.id) |
    +-----------------------+
    |                 38250 |
    +-----------------------+
    1 row in set (0.07 sec) 

While spelunking, I think I found (part of) the bug:

mysql> select distinct slug from taggit_tag where slug like 'profile%javascript';
+-------------------------------------------+
| slug                                      |
+-------------------------------------------+
| profileexpertisejavascript                |
| profileinterestjavascript                 |
| profileinterestlove-javascript            |
| profileinterestobject-oriented-javascript |
| profileinterestuse-of-javascript          |
+-------------------------------------------+
5 rows in set (0.02 sec)

Looks like we accidentally removed the ':' characters from the profile:interest and profile:expertise tag slugs. I couldn't find a specific migration that did it.

But since this will involve a data migration AND code updates, I estimate a LOE:5.
Flags: needinfo?(lcrouch)
Whiteboard: [specification][type:bug] → [specification][type:bug][LOE:5]
Oh, and there are 79k MDN users. So 8k/79k is 10% of registered users.
Considering the minority who've successfully used this feature, and considering the LOE, I suggest we disable it on the form for now but don't make any changes to profile model or data. Just remove the broken form fields.
Commit pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/634b171f76c44b831197c3dca32c979b64325c12
Fix bugs 1271503, 1274688, 1036150, 712337: Fix profile format and errors.

Fix bug 1271503: Reformat profile.
Moved user links into main profile section. Removed styling for user-photo because it assumed user-links were after it. Reformatted user links to be inline. Some RTL fixes

Fix bug 1274688: JS error on profile.
Included jQuery UI to stop JS errors

Fix bug 1036150: Can't add expertise.
Changed from .attr(checked) to .prop(checked).

Fix bug 712337: Improve expertise.
Show expertise field only if there is expertise for the user to check.

Updated

a year ago
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.