Closed Bug 1036232 Opened 6 years ago Closed 6 years ago

Followup of Bug 1006315: Remove redundant code of entering compartment

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S1 (1aug)

People

(Reporter: yrliou, Assigned: yrliou)

References

Details

(Whiteboard: webbt-api, p=1)

Attachments

(1 file, 1 obsolete file)

This is a followup of bug 1006315.
Since now AutoJSAPI::Init already enters the right compartment for us,
we can remove some redundant code of manually entering compartment in BluetoothManager and BluetoothAdapter.
Whiteboard: webbt-api → webbt-api, p=1
Target Milestone: --- → 2.0 S6 (18july)
Remove compartment entering code since JSAPI::Init already done that.
Attachment #8462379 - Flags: review?(btian)
Comment on attachment 8462379 [details] [diff] [review]
Bug 1036232 - Remove redundant code of entering compartment in BT manager and adapter.

Review of attachment 8462379 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed. Thanks.

::: dom/bluetooth2/BluetoothAdapter.cpp
@@ +871,2 @@
>  
>    if(!ToJSValue(cx, aTypes, &value)) {

nit: space after |if|.

::: dom/bluetooth2/BluetoothManager.cpp
@@ +252,1 @@
>    JS::Rooted<JS::Value> value(cx, JS::NullValue());

Remove |JS::NullValue()| as in |BluetoothAdapter::DispatchAttributeEvent|.
Attachment #8462379 - Flags: review?(btian) → review+
Target Milestone: 2.0 S6 (18july) → 2.1 S1 (1aug)
* No try server link since dom/bluetooth2 won't be build on try server.
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.