1036298 - [Keyboard] “Alt” key UI consistency

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Carol Huang [:Carol]]

Capitalization issue. Need to change "ALT" to "Alt"

Comment 1

[Carol Huang [:Carol]]

Please change "ALT" to "Alt" for all the build-in keyboards, thanks!!!

Comment 2

[Sudheesh Singanamalla (:ShellHacker)]

Can I take this up ?

Comment 3

[Sudheesh Singanamalla (:ShellHacker)]

I figured out that the path is : apps/keyboard/js/layouts/en.js where the string

{ value: 'ALT', ratio: 1.5, keyCode: KeyEvent.DOM_VK_ALT },

has to be converted to

{ value: 'Alt', ratio: 1.5, keyCode: KeyEvent.DOM_VK_ALT },

And this has to be done for all Locales, Am I in the right direction ? Or is there an easier procedure ?

Comment 4

[Sudheesh Singanamalla (:ShellHacker)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/22383

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8465931 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/22383

Looks good to me, r+.
Thanks for the contribution!

--
Sorry that didn't respond to your previous comments, generally, I won't be notified unless you set review flag to or "needinfo" me. 

Will land this once the CI passes.
https://tbpl.mozilla.org/?rev=149f3b32d7d3a1afdee8c5bb5048006abc378867&tree=Gaia-Try

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/e880a4c0666d5dc575c8ea25770c3c5c4cdfab82
--
The CI failure should be irrelevant to this change.

Comment 7

[Shine(Leave from Mozilla)]

Attachment: video

This issue has been verified successfully on Flame 2.1
See attachment: Verify_1036298.MP4
Reproducing rate: 0/5
Reproducing steps:
1.	Launch Settings -> Tap “Keyboards” -> Tap “Select keyboards” and enable all the build-in keyboards.
2.	Enter any compose view and bring up keyboard.
3.	Switch all the build-in keyboard types.
** All the "ALT" are change to "Alt".

Flame 2.1 build:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141202001201
Version         34.0