1036425 - Minor release-runner.sh improvements

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect, P3)

Description

[Sylvestre Ledru [:Sylvestre]]

Attachment: 0001-Check-the-input-arguments.patch

I know it is a bit of a bikeshed but I like the script I use when they check their arguments.
+
the patch uses the "notify_to" value from the ini file instead of the hardcoded value.

Comment 1

[Rail Aliiev [:rail]]

Comment on attachment 8453079 [details] [diff] [review]
0001-Check-the-input-arguments.patch

Review of attachment 8453079 [details] [diff] [review]:
-----------------------------------------------------------------

::: buildfarm/release/release-runner.sh
@@ +16,5 @@
>  if [ -z "$LOGFILE" ]; then
>      LOGFILE=/var/log/supervisor/release-runner.log
>  fi
> +
> +touch $LOGFILE &> /dev/null

I don't think this will work. The script runs as ctlbld, but the log file is owned by root. supervisord logs whatever the script prints to stdout/stderr, not the script itself.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Attachment: 0001-Check-the-input-arguments.patch

Right. I am not checking that the directory of LOGFILE exists.

Comment 3

[Rail Aliiev [:rail]]

Comment on attachment 8454408 [details] [diff] [review]
0001-Check-the-input-arguments.patch

Review of attachment 8454408 [details] [diff] [review]:
-----------------------------------------------------------------

::: buildfarm/release/release-runner.sh
@@ +39,4 @@
>  
>  # Sleep time after a failure, in seconds.
>  SLEEP_TIME=60
> +NOTIFY_TO=$(grep "notify_to:" $CONFIG|sed -e "s|.*<\(.*\)>|\1|g")

Can you test if the value is empty and fallback to release@ if it's empty?

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Attachment: 0001-Check-the-input-arguments.patch

Sure. done!

Comment 5

[Rail Aliiev [:rail]]

Comment on attachment 8454425 [details] [diff] [review]
0001-Check-the-input-arguments.patch

Feel free to land it anytime. Just ping me to deploy it.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8454425 [details] [diff] [review]
0001-Check-the-input-arguments.patch

Checked in:
https://hg.mozilla.org/build/tools/rev/7f3a0e70a2ab

Deploy when you want. It should not change anything on your side.

Comment 7

[[e-mail] (:bhearsum)]

Looks like this was deployed already.