Minor release-runner.sh improvements

RESOLVED FIXED

Status

Release Engineering
Release Automation: Other
P3
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: sylvestre, Assigned: sylvestre)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [shipit])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

4 years ago
Created attachment 8453079 [details] [diff] [review]
0001-Check-the-input-arguments.patch

I know it is a bit of a bikeshed but I like the script I use when they check their arguments.
+
the patch uses the "notify_to" value from the ini file instead of the hardcoded value.
Attachment #8453079 - Flags: review?(bhearsum)
Comment on attachment 8453079 [details] [diff] [review]
0001-Check-the-input-arguments.patch

Review of attachment 8453079 [details] [diff] [review]:
-----------------------------------------------------------------

::: buildfarm/release/release-runner.sh
@@ +16,5 @@
>  if [ -z "$LOGFILE" ]; then
>      LOGFILE=/var/log/supervisor/release-runner.log
>  fi
> +
> +touch $LOGFILE &> /dev/null

I don't think this will work. The script runs as ctlbld, but the log file is owned by root. supervisord logs whatever the script prints to stdout/stderr, not the script itself.
(Assignee)

Comment 2

4 years ago
Created attachment 8454408 [details] [diff] [review]
0001-Check-the-input-arguments.patch

Right. I am not checking that the directory of LOGFILE exists.
Attachment #8453079 - Attachment is obsolete: true
Attachment #8453079 - Flags: review?(bhearsum)
Attachment #8454408 - Flags: review?(rail)
Comment on attachment 8454408 [details] [diff] [review]
0001-Check-the-input-arguments.patch

Review of attachment 8454408 [details] [diff] [review]:
-----------------------------------------------------------------

::: buildfarm/release/release-runner.sh
@@ +39,4 @@
>  
>  # Sleep time after a failure, in seconds.
>  SLEEP_TIME=60
> +NOTIFY_TO=$(grep "notify_to:" $CONFIG|sed -e "s|.*<\(.*\)>|\1|g")

Can you test if the value is empty and fallback to release@ if it's empty?
Attachment #8454408 - Flags: review?(rail) → review+
(Assignee)

Comment 4

4 years ago
Created attachment 8454425 [details] [diff] [review]
0001-Check-the-input-arguments.patch

Sure. done!
Attachment #8454408 - Attachment is obsolete: true
Comment on attachment 8454425 [details] [diff] [review]
0001-Check-the-input-arguments.patch

Feel free to land it anytime. Just ping me to deploy it.
Attachment #8454425 - Flags: review+
(Assignee)

Comment 6

4 years ago
Comment on attachment 8454425 [details] [diff] [review]
0001-Check-the-input-arguments.patch

Checked in:
https://hg.mozilla.org/build/tools/rev/7f3a0e70a2ab

Deploy when you want. It should not change anything on your side.
Attachment #8454425 - Flags: checked-in+
Assignee: nobody → sledru
Looks like this was deployed already.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.