1036449 - CSS Coverage start should begin with a page refresh

Status: RESOLVED FIXED

(DevTools :: Style Editor, defect)

Description

[Joe Walker [:jwalker]]

Downsides:

* Refreshing a page might be annoying in some cases
  But just about to start a coverage test probably isn't one of those

Upsides:

* Coverage will work the way people expect more

Comment 1

[Girish Sharma [:Optimizer]]

What about the use that I start css coverage, visit 3-4 diff. pages which have the same CSS and then stop the coverage to know the real coverage of my CSS file.

This is a very good use case as many people share the CSS files across pages and the file is not completely used one each single page, but collectively, the file's usage is almost 100%.

Devs might want to figure out the extra things that make it almost 100% rather than 100%

Comment 2

[Joe Walker [:jwalker]]

(In reply to Girish Sharma [:Optimizer] from comment #1)
> What about the use that I start css coverage, visit 3-4 diff. pages which
> have the same CSS and then stop the coverage to know the real coverage of my
> CSS file.

That requirement is supported, and isn't changed by this bug.

Comment 3

[Girish Sharma [:Optimizer]]

So after this bug, the csscoverage report won't restart after every (re)load ? but will only start after the first reload ?

Comment 4

[Joe Walker [:jwalker]]

(In reply to Girish Sharma [:Optimizer] from comment #3)
> So after this bug, the csscoverage report won't restart after every (re)load
> ? but will only start after the first reload ?

No. It's saying the pressing the start button reloads the current page.

Comment 5

[Girish Sharma [:Optimizer]]

Ah, my bad.

Comment 6

[Joe Walker [:jwalker]]

Attachment: 0002-Bug-1036449-Introduce-a-noreload-flag-for-csscoverag.patch

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/33f1bc57b49c

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/33f1bc57b49c