Add deprecation warnings for location and size on element

RESOLVED FIXED in mozilla34

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: automatedtester, Assigned: automatedtester)

Tracking

({pi-marionette-spec})

unspecified
mozilla34
x86
Mac OS X
pi-marionette-spec
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
in bug 1036365 we need to add deprecation warnings for location and size since these have been superceeded by getElementRect
(Assignee)

Comment 1

4 years ago
when doing this we will also need to correct location and see if there are broken tests for that
(Assignee)

Comment 2

4 years ago
Created attachment 8462779 [details] [diff] [review]
Add deprecation warnings to HTMLElement#size and HTMLElement#location in Marionette
(Assignee)

Updated

4 years ago
Assignee: nobody → dburns
Status: NEW → ASSIGNED
(Assignee)

Updated

4 years ago
Attachment #8462779 - Flags: review?(jgriffin)
Comment on attachment 8462779 [details] [diff] [review]
Add deprecation warnings to HTMLElement#size and HTMLElement#location in Marionette

Review of attachment 8462779 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/client/marionette/marionette.py
@@ +141,5 @@
>      def size(self):
>          '''
>          A dictionary with the size of the element.
>          '''
> +        warnings.warn("This property has been deprecated and will be removed in a future version. \

Should we say 'The size property', rather than 'This property'?

@@ +163,5 @@
>  
>          :returns: a dictionary containing x and y as entries
>  
>          """
> +        warnings.warn("This property has been deprecated and will be removed in a future version. \

Same as above.
Attachment #8462779 - Flags: review?(jgriffin) → review+
(Assignee)

Updated

4 years ago
Keywords: ateam-marionette-spec
https://hg.mozilla.org/mozilla-central/rev/bd63119d9f36
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
David, DeprecationWarning is ignored by default. Do we need to turn on the warnings filter to let user know location and size will be deprecated?
You need to log in before you can comment on or make changes to this bug.