1036498 - Add deprecation warnings for location and size on element

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[David Burns :automatedtester]

in bug 1036365 we need to add deprecation warnings for location and size since these have been superceeded by getElementRect

Comment 1

[David Burns :automatedtester]

when doing this we will also need to correct location and see if there are broken tests for that

Comment 2

[David Burns :automatedtester]

Attachment: Add deprecation warnings to HTMLElement#size and HTMLElement#location in Marionette

Comment 3

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8462779 [details] [diff] [review]
Add deprecation warnings to HTMLElement#size and HTMLElement#location in Marionette

Review of attachment 8462779 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/client/marionette/marionette.py
@@ +141,5 @@
>      def size(self):
>          '''
>          A dictionary with the size of the element.
>          '''
> +        warnings.warn("This property has been deprecated and will be removed in a future version. \

Should we say 'The size property', rather than 'This property'?

@@ +163,5 @@
>  
>          :returns: a dictionary containing x and y as entries
>  
>          """
> +        warnings.warn("This property has been deprecated and will be removed in a future version. \

Same as above.

Comment 4

[David Burns :automatedtester]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bd63119d9f36

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bd63119d9f36

Comment 6

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

David, DeprecationWarning is ignored by default. Do we need to turn on the warnings filter to let user know location and size will be deprecated?