Closed Bug 1036531 Opened 11 years ago Closed 11 years ago

nsTimerImpl is a can of worms

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1036550

People

(Reporter: bwc, Unassigned)

References

Details

(Keywords: sec-audit)

There have been a number of sec bugs filed on nsTimerImpl recently, and the picture emerging is that it is broadly dangerous from a security perspective, and racy in several ways that can cause incorrect behavior. This will probably require substantial rewriting, and we should also take the time to improve the unit-testing of nsITimer to cover more use-cases, and make sure TSAN is happy.
Is this bug specifically about tests, or about a general redesign? If somebody is interested in a redesign, I have some design thoughts, but I'd prefer to put them in a public redesign bug.
I think a redesign may be required, but whatever we do it needs to be accompanied with better testing.
ok. I don't think a bug about better stress-testing nor a bug about a redesign need to be private, so I'm going to file new ones and then dup this one forward.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → INVALID
Filed bug 1036548 and bug 1036550.
Resolution: INVALID → DUPLICATE
Group: core-security → core-security-release
Group: core-security-release
Keywords: sec-audit
You need to log in before you can comment on or make changes to this bug.