'make check' fails unless MOZ_OBJDIR is in the environment

RESOLVED FIXED in mozilla33

Status

()

Core
Build Config
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mshal, Assigned: mshal)

Tracking

Trunk
mozilla33
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Since bug 762358, selftest.py always tries to pop MOZ_OBJDIR, which fails if it doesn't exist:

make[1]: Entering directory `/home/marf/mozilla-central-git/obj-x86_64-unknown-linux-gnu/testing/xpcshell'
Traceback (most recent call last):
  File "/home/marf/mozilla-central-git/testing/xpcshell/selftest.py", line 15, in <module>
    os.environ.pop('MOZ_OBJDIR')
  File "/home/marf/mozilla-central-git/obj-x86_64-unknown-linux-gnu/_virtualenv/lib/python2.7/os.py", line 503, in pop
    return self.data.pop(key, *args)
KeyError: 'MOZ_OBJDIR'
(Assignee)

Comment 1

4 years ago
Created attachment 8453232 [details] [diff] [review]
0001-Bug-1036557-Fix-make-check-with-no-MOZ_OBJDIR.patch
Assignee: nobody → mshal
Attachment #8453232 - Flags: review?(mh+mozilla)
Attachment #8453232 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/36bc028ec5c5
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.