Closed Bug 1036557 Opened 10 years ago Closed 10 years ago

'make check' fails unless MOZ_OBJDIR is in the environment

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla33

People

(Reporter: mshal, Assigned: mshal)

Details

Attachments

(1 file)

0001-Bug-1036557-Fix-make-check-with-no-MOZ_OBJDIR.patch
787 bytes, patch
glandium
: review+
Details | Diff | Splinter Review 
Since bug 762358, selftest.py always tries to pop MOZ_OBJDIR, which fails if it doesn't exist:

make[1]: Entering directory `/home/marf/mozilla-central-git/obj-x86_64-unknown-linux-gnu/testing/xpcshell'
Traceback (most recent call last):
  File "/home/marf/mozilla-central-git/testing/xpcshell/selftest.py", line 15, in <module>
    os.environ.pop('MOZ_OBJDIR')
  File "/home/marf/mozilla-central-git/obj-x86_64-unknown-linux-gnu/_virtualenv/lib/python2.7/os.py", line 503, in pop
    return self.data.pop(key, *args)
KeyError: 'MOZ_OBJDIR'
Assignee: nobody → mshal

        Attachment #8453232 -
        Flags: review?(mh+mozilla)

        Attachment #8453232 -
        Flags: review?(mh+mozilla) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/36bc028ec5c5
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33

    
  
Product: Core → Firefox Build System

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: