Closed Bug 1036574 Opened 10 years ago Closed 9 years ago

Revert horrible workaround in ICGetProp_ArgumentsCallee when we switch off Android NDK r8e

Categories

(Core :: JavaScript Engine: JIT, defect)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla42
Tracking Flags:
Tracking Status
firefox42 --- fixed

People

(Reporter: shu, Unassigned)

Details

See the horrible hack here: https://hg.mozilla.org/integration/mozilla-inbound/rev/1546c3578328#l1.29

I had to push this to work around a GCC bug for ARMv6 codegen. We should revert this when we stop supporting Android <= 2.3, or ARMv6, or upgrade the NDK > r8e on TBPL.
We are no longer supporting Android 2.2 or ARM v6, and are now building against NDK r10e. Shu-yu do you want to revert this now?
Try push here for reverting: https://hg.mozilla.org/try/rev/0d251d63cb3f
Flags: needinfo?(shu)
https://hg.mozilla.org/mozilla-central/rev/b6362a1d6189
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.