Closed Bug 1036581 Opened 5 years ago Closed 5 years ago

Telemetry for SocialAPI

Categories

(Firefox Graveyard :: SocialAPI, defect)

32 Branch
x86
macOS
defect
Not set

Tracking

(firefox32 fixed, firefox33 fixed)

RESOLVED FIXED
Firefox 33
Tracking Status
firefox32 --- fixed
firefox33 --- fixed

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

Details

Attachments

(2 files, 2 obsolete files)

While FHR gives us install rates for social providers, we have no actual usage data.  We need to add hooks for:

- opening share/status/bookmark toolbar buttons
- sidebar opened/closed at session start
- sidebar opened/closed during session
- sidebar changed
Assignee: nobody → mixedpuppy
Attachment #8453357 - Flags: review?(benjamin)
Patch update after further conversations with dolske, jjensen, and BD.
Attachment #8453357 - Attachment is obsolete: true
Attachment #8453357 - Flags: review?(benjamin)
Attachment #8455441 - Flags: review?(dolske)
remove unused code line missed in my last pass.
Attachment #8455441 - Attachment is obsolete: true
Attachment #8455441 - Flags: review?(dolske)
Attachment #8455443 - Flags: review?(dolske)
some slight differences for aurora due to some refactoring that has happened only on nightly.
Attachment #8455484 - Flags: review?(dolske)
Attachment #8455443 - Flags: review?(dolske) → review+
Attachment #8455484 - Flags: review?(dolske) → review+
new try for fx33 since the first one had issues (apparently unrelated to this patch)
https://tbpl.mozilla.org/?tree=Try&rev=8433dd1ef260
Comment on attachment 8455484 [details] [diff] [review]
add telemetry to social sidebar and buttons (aurora)

Approval Request Comment
[Feature/regressing bug #]: new telemetry hooks for socialapi
[User impact if declined]: none
[Describe test coverage new/current, TBPL]: existing tests pass, try's on tbpl
[Risks and why]: low
[String/UUID change made/needed]: none
Attachment #8455484 - Flags: approval-mozilla-aurora?
Flags: needinfo?(lmandel)
https://hg.mozilla.org/mozilla-central/rev/6c0b6745b7dc
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Attachment #8455484 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.