103664 - Clean up tests to use 'use strict' and TEST_VERBOSE

Status: RESOLVED FIXED

(Bugzilla :: Testing Suite, defect)

Description

[David D. Kilzer (ddk)]

The soon-to-be-attached patch will do the following:

1. Change use 'VERBOSE' environment variable when running tests to use
   'TEST_VERBOSE' instead.  This is what ExtUtils::MakeMaker uses when
   generating a Makefile from Makefile.PL.  The runtests.sh script and
   the test scripts should do the same.

2. Add 'use strict;' to all test scripts and clean up undeclared
   variables.

3. Add $verbose variable to t/002goodperl.t in case it is needed later.

4. Remove "sillyness" from t/001compile.t for $warnings variable
   (which really should have been %warnings).

5. Clean up package name of t/Support/Systemexec.pm from 'Systemexec'
   to 'Support::Systemexec' and fix t/003safesys.t to use the proper
   syntax for the module.

6. Fix regex in t/003safesys.t when testing for error messages from 
   improper exec() calls.

Comment 1

[David D. Kilzer (ddk)]

Attachment: patch v1

Comment 2

[David D. Kilzer (ddk)]

Why was I able to assign the bug to [e-mail] when I was
logged in as [e-mail]?  I own the bug, bug I
didn't think I could assign the bug to someone just as the bug
owner?

Reassigning to myself.

Comment 3

[David D. Kilzer (ddk)]

Attachment: patch v2

Comment 4

[David D. Kilzer (ddk)]

Attachment 53576 [details] [diff] (bugzilla-2.15-20011014-CVS-fix-tests.diff) does the
following in addition to 'patch v1':

  o Fixes items 1 and 2 for t/005no_tabs.t.
  o Fixes typo "#Bugzilla Test 4#" (should be "5") in t/005no_tabs.t.
  o Changes spaces to tabs (a la Bug 104516) in:
    t/001compile.t
    t/002goodperl.t
    t/003safesys.t
    t/Support/Files.pm
    t/Support/Templates.pm

Please note that 'patch v1' should be obsoleted, but I don't have
privileges to do that (shouldn't a bug owner be able to edit the
status of patches to the bugs s/he owns?).

Comment 5

[Jacob Steenhagen]

Comment on attachment 53576 [details] [diff] [review]
patch v2

Looks good to me.

Comment 6

[Jacob Steenhagen]

Checked in.