Closed Bug 1036648 Opened 10 years ago Closed 10 years ago

WebappOSUtils.uninstall resolves promise after failing to move app to Trash

Categories

(Firefox Graveyard :: Webapp Runtime, defect)

Product:
Firefox Graveyard
Component:
Webapp Runtime
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 33

People

(Reporter: myk, Assigned: marco)

Details

Attachments

(1 file)

Patch
1013 bytes, patch
myk
: review+
Details | Diff | Splinter Review 
WebappOSUtils.uninstall resolves its promise when it fails to move an app to the Trash on Mac:

http://mxr.mozilla.org/mozilla-central/source/toolkit/webapps/WebappOSUtils.jsm?rev=05d9e7977182#345

It should reject its promise instead.
Attached patch Patch — — Splinter Review 
Oops, typo error from bug 991766...
Assignee: nobody → mar.castelluccio
Status: NEW → ASSIGNED
Attachment #8453466 - Flags: review?(myk)
(I've sent the patch to try to make sure it does work: https://tbpl.mozilla.org/?tree=Try&rev=f6788ba9738e)
Attachment #8453466 - Flags: review?(myk) → review+
https://hg.mozilla.org/mozilla-central/rev/315da0e3c1b4
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: