1036751 - Test webapp runtime executable update

Status: RESOLVED FIXED

(Firefox Graveyard :: Webapp Runtime, defect)

Description

[Marco Castelluccio [:marco]]

Attachment: Patch

This test exercises the code that deals with the update of the webapprt executable.

I know the test is a bit twisted, but I think there's value in testing this code.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 8453485 [details] [diff] [review]
Patch

Review of attachment 8453485 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Marco Castelluccio [:marco] from comment #0)
> I know the test is a bit twisted, but I think there's value in testing this
> code.

Indeed!  And this approach seems reasonable!

Comment 2

[Marco Castelluccio [:marco]]

Attachment: Patch

It's green on try: https://tbpl.mozilla.org/?tree=Try&rev=57120e0a60f6

I've pushed another try run to see if we need to disable the test on ASAN builds.

Comment 3

[Marco Castelluccio [:marco]]

Green on ASAN: https://tbpl.mozilla.org/?tree=Try&rev=142925233a90

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 8454128 [details] [diff] [review]
Patch

Review of attachment 8454128 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great!

Comment 5

[Marco Castelluccio [:marco]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9f869623bd08

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9f869623bd08