Test webapp runtime executable update

RESOLVED FIXED in Firefox 33

Status

defect
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: marco, Assigned: marco)

Tracking

Trunk
Firefox 33
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Posted patch Patch (obsolete) — Splinter Review
This test exercises the code that deals with the update of the webapprt executable.

I know the test is a bit twisted, but I think there's value in testing this code.
Attachment #8453485 - Flags: feedback?(myk)
Comment on attachment 8453485 [details] [diff] [review]
Patch

Review of attachment 8453485 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Marco Castelluccio [:marco] from comment #0)
> I know the test is a bit twisted, but I think there's value in testing this
> code.

Indeed!  And this approach seems reasonable!
Attachment #8453485 - Flags: feedback?(myk) → feedback+
Posted patch PatchSplinter Review
It's green on try: https://tbpl.mozilla.org/?tree=Try&rev=57120e0a60f6

I've pushed another try run to see if we need to disable the test on ASAN builds.
Assignee: nobody → mar.castelluccio
Attachment #8453485 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8454128 - Flags: review?(myk)
Comment on attachment 8454128 [details] [diff] [review]
Patch

Review of attachment 8454128 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great!
Attachment #8454128 - Flags: review?(myk) → review+
https://hg.mozilla.org/mozilla-central/rev/9f869623bd08
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Depends on: 1058109
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.