Closed
Bug 1036776
Opened 10 years ago
Closed 10 years ago
Replace MOZ_ASSUME_UNREACHABLE with MOZ_ASSERT_UNREACHABLE in dom/
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla33
Tracking | Status | |
---|---|---|
firefox32 | --- | unaffected |
firefox33 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(1 file)
910 bytes,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
One more call to the deprecated MOZ_ASSUME_UNREACHABLE macro name has appeared in dom/ code. (MOZ_ASSUME_UNREACHABLE will eventually be renamed in bug 990764.) MOZ_ASSERT_UNREACHABLE only asserts in debug builds. Can this be a fatal MOZ_CRASH instead?
Attachment #8453540 -
Flags: review?(bugs)
Comment 1•10 years ago
|
||
Comment on attachment 8453540 [details] [diff] [review] replace-dom-MOZ_ASSUME_UNREACHABLE.patch This can be MOZ_ASSERT
Attachment #8453540 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/121c4677c64b
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/121c4677c64b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•