Replace MOZ_ASSUME_UNREACHABLE with MOZ_ASSERT_UNREACHABLE in dom/

RESOLVED FIXED in Firefox 33

Status

()

Core
DOM
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

unspecified
mozilla33
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox32 unaffected, firefox33 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 8453540 [details] [diff] [review]
replace-dom-MOZ_ASSUME_UNREACHABLE.patch

One more call to the deprecated MOZ_ASSUME_UNREACHABLE macro name has appeared in dom/ code. (MOZ_ASSUME_UNREACHABLE will eventually be renamed in bug 990764.)

MOZ_ASSERT_UNREACHABLE only asserts in debug builds. Can this be a fatal MOZ_CRASH instead?
Attachment #8453540 - Flags: review?(bugs)

Comment 1

4 years ago
Comment on attachment 8453540 [details] [diff] [review]
replace-dom-MOZ_ASSUME_UNREACHABLE.patch

This can be MOZ_ASSERT
Attachment #8453540 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/121c4677c64b
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.