Closed Bug 1036778 Opened 10 years ago Closed 10 years ago

Replace MOZ_ASSUME_UNREACHABLE with MOZ_CRASH in js/xpconnect

Categories

(Core :: XPConnect, defect)

Product:
Core
Component:
XPConnect
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla33
Tracking Flags:
Tracking Status
firefox32 --- wontfix
firefox33 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

replace-xpconnect-MOZ_ASSUME_UNREACHABLE.patch
2.15 KB, patch
bholley
: review+
Details | Diff | Splinter Review 
Replace calls to the deprecated MOZ_ASSUME_UNREACHABLE macro with MOZ_CRASH.

Calls to MOZ_NOT_REACHED() were replaced with MOZ_ASSUME_UNREACHABLE which, instead of crashing unconditionally, invokes undefined behavior in the name of dubious and dangerous compiler optimizations. See bug 990764 for details.

(MOZ_ASSUME_UNREACHABLE will eventually be removed or renamed in bug 990764.)
Attachment #8453541 - Flags: review?(bobbyholley)
Attachment #8453541 - Flags: review?(bobbyholley) → review+
https://hg.mozilla.org/mozilla-central/rev/b4e66f3f59f8
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: