Closed Bug 1036823 Opened 10 years ago Closed 10 years ago

[Vertical homescreen] Remove 'install' message for bookmarks because it is not supported

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Homescreen
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.0 fixed, b2g-v2.1 fixed)

Status:
RESOLVED FIXED
Milestone:
2.0 S6 (18july)
Tracking Flags:
Tracking Status
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: crdlc, Assigned: crdlc)

References

Details

(Whiteboard: [systemsfe])

Attachments

(4 files)

Github pull request
190 bytes, text/html
kgrandon
: review+
bajaj
: approval-gaia-v2.0+
Details
Flame2.1&2.0 video
9.40 MB, video/mp4
Details
Flame2.0 logcat
74.59 KB, text/plain
Details
Flame2.1 logcat
93.26 KB, text/plain
Details
Whiteboard: [systemsfe]
Assignee: nobody → crdlc
Blocks: 1015336
Status: NEW → ASSIGNED
See Also: → 1036355
Attached file Github pull request — 

        Attachment #8453618 -
        Flags: review?(kgrandon)
Blocks: vertical-home-next
No longer blocks: 1015336
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking-]

    
    

    
  
Comment on attachment 8453618 [details]
Github pull request

Looks good to me.

        Attachment #8453618 -
        Flags: review?(kgrandon) → review+

    
    

    
  
Master: https://github.com/mozilla-b2g/gaia/commit/7d0005cc60a390fa2c8ffd7fdd89e1d5dbcc9af0
Blocks: vertical-homescreen
No longer blocks: vertical-home-next
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 8453618 [details]
Github pull request

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

The risk is null and we can save memory and battery avoiding a huge process and not needed when user install bookmarks on the homescreen

        Attachment #8453618 -
        Flags: approval-gaia-v2.0?(bbajaj)
Target Milestone: --- → 2.0 S6 (18july)

        Attachment #8453618 -
        Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+

    
    

    
  
Dear Cristian,
Could you please provide a repro video or steps, thanks!
Flags: needinfo?(crdlc)

    
    

    
  
I am not working right now here but AFAIR the STR were

1) Go to homescreen
2) Open http://www.facebook.com
3) Click on the star icon
3) Add this bookmark to homescreen

Expected:

Social collection has this new bookmark in its list of pinned icons

Result:

No bookmark in social smart collection
Flags: needinfo?(crdlc)

    
    

    
  

      
      
      
      

        Attached video
          
        Flame2.1&2.0 video
        — 
      

    


  
This bug has been verified to fail on Flame2.0 and 2.1.
See attachment: Flame2.1&2.0_video.MP4 & Flame2.0_logcat_1746.txt & Flame2.1_logcat_2055.txt
Reproducing rate: 3/3
Reproducing steps:
1. Go to homescreen
2. Open http://www.facebook.com
3. Click on the star icon -> “Add to home screen”-> “Done” (Tap Menu -> Tap “Add to home screen” -> Tap “Done”)
4. Go back to Home screen.
** The bookmark can't display in social smart collection.

Flame 2.0 build:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141202000201
Version         32.0

Flame 2.1 build:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141202001201
Version         34.0
Flags: needinfo?(hlu)
Flags: needinfo?(hlu)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: