1036823 - [Vertical homescreen] Remove 'install' message for bookmarks because it is not supported

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Cristian Rodriguez (:crdlc)]

See bug 1036355

Comment 1

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8453618 [details]
Github pull request

Looks good to me.

Comment 3

[Kevin Grandon :kgrandon]

Master: https://github.com/mozilla-b2g/gaia/commit/7d0005cc60a390fa2c8ffd7fdd89e1d5dbcc9af0

Comment 4

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8453618 [details]
Github pull request

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

The risk is null and we can save memory and battery avoiding a huge process and not needed when user install bookmarks on the homescreen

Comment 5

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/0e0c95c9db6082ed9d043037e18dbda66a2803a0

Comment 6

[Shine(Leave from Mozilla)]

Dear Cristian,
Could you please provide a repro video or steps, thanks!

Comment 7

[Cristian Rodriguez (:crdlc)]

I am not working right now here but AFAIR the STR were

1) Go to homescreen
2) Open http://www.facebook.com
3) Click on the star icon
3) Add this bookmark to homescreen

Expected:

Social collection has this new bookmark in its list of pinned icons

Result:

No bookmark in social smart collection

Comment 8

[Shine(Leave from Mozilla)]

Attachment: Flame2.1&2.0 video

This bug has been verified to fail on Flame2.0 and 2.1.
See attachment: Flame2.1&2.0_video.MP4 & Flame2.0_logcat_1746.txt & Flame2.1_logcat_2055.txt
Reproducing rate: 3/3
Reproducing steps:
1. Go to homescreen
2. Open http://www.facebook.com
3. Click on the star icon -> “Add to home screen”-> “Done” (Tap Menu -> Tap “Add to home screen” -> Tap “Done”)
4. Go back to Home screen.
** The bookmark can't display in social smart collection.

Flame 2.0 build:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141202000201
Version         32.0

Flame 2.1 build:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141202001201
Version         34.0

Comment 9

[Shine(Leave from Mozilla)]

Attachment: Flame2.0 logcat

Comment 10

[Shine(Leave from Mozilla)]

Attachment: Flame2.1 logcat