1036843 - [tarako][flame][1.3][1.4]launching the wrong app after sliding the page

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[ying.xu]

STR:

1. homscreen, slide page1(e.me) to page2
2. launching setting app immediately after seeing page2
3. with high possibilities, camera was launched.

a video has been uploaded, you need do this more faster than doing in the video

the bug exists with both 1.3t/1.4 branch

Comment 1

[ying.xu]

Attachment: patch

a simple patch to workaround

Comment 2

[ying.xu]

Attachment: recordaa

part1

Comment 3

[ying.xu]

Attachment: recordab

part2

Comment 4

[ying.xu]

download the attachment of comment2/3

run 
cat recorda* > record.mp4

you get the record

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Don't think this is a system app bug if the webapps-launch event is correct.

Comment 6

[Cristian Rodriguez (:crdlc)]

What is the need info here? for the patch? I don't have nor tarako neither flame. I cannot see the video although the explanation is enough thought.

Comment 7

[Ivan Tsay (:ITsay)]

Hi Ying,

Is the patch you attached here for review?

Comment 8

[ying.xu]

I‘ll be appreciated if you review it.

this patch is for 1.3t.

If needed, I will create a PR for master

Comment 9

[Ivan Tsay (:ITsay)]

Ying,

Please ni? me when your master patch is ready. I will try to find reviewer for you.

Comment 10

[ying.xu]

Attachment: PR@master

Comment 11

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8459413 [details] [review]
PR@master

LGTM, please address a comment in github

Comment 12

[ying.xu]

updated code as comment11

 function goToPage(index, callback) {
- if (index < 0 || index >= pages.length)
+ if (index < 0 || index >= pages.length) {
+ if (callback) {
+ setTimeout(callback, 0);
+ }
return;
+ }

Comment 13

[Ivan Tsay (:ITsay)]

Minor issue and remove the noms for now.

Comment 14

[Kevin Grandon :kgrandon]

Mass update: Resolve wontfix all issues with legacy homescreens.

As of 2.6 we have a new homescreen and having these issues open is confusing. All issues will block bug 1231115 so we can use that to re-visit any of these if needed.