Closed Bug 1036843 Opened 6 years ago Closed 4 years ago

[tarako][flame][1.3][1.4]launching the wrong app after sliding the page

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect, critical)

ARM
Gonk (Firefox OS)
defect
Not set
critical

Tracking

(b2g-v1.3T affected)

RESOLVED WONTFIX
Tracking Status
b2g-v1.3T --- affected

People

(Reporter: ying.xu, Assigned: ying.xu)

References

Details

Attachments

(4 files)

902 bytes, patch
Details | Diff | Splinter Review
8.00 MB, video/3gpp
Details
5.41 MB, application/octet-stream
Details
46 bytes, text/x-github-pull-request
crdlc
: review+
Details | Review
STR:

1. homscreen, slide page1(e.me) to page2
2. launching setting app immediately after seeing page2
3. with high possibilities, camera was launched.

a video has been uploaded, you need do this more faster than doing in the video

the bug exists with both 1.3t/1.4 branch
Attached patch patchSplinter Review
a simple patch to workaround
Attached video recordaa
part1
Attached file recordab
part2
download the attachment of comment2/3

run 
cat recorda* > record.mp4

you get the record
blocking-b2g: --- → 1.4?
Flags: needinfo?(alive)
Don't think this is a system app bug if the webapps-launch event is correct.
Flags: needinfo?(alive)
Flags: needinfo?(crdlc)
What is the need info here? for the patch? I don't have nor tarako neither flame. I cannot see the video although the explanation is enough thought.
Flags: needinfo?(crdlc)
Attachment #8453640 - Attachment is patch: true
Attachment #8453640 - Attachment mime type: text/x-patch → text/plain
Assignee: nobody → ying.xu
Hi Ying,

Is the patch you attached here for review?
Flags: needinfo?(ying.xu)
I‘ll be appreciated if you review it.

this patch is for 1.3t.

If needed, I will create a PR for master
Flags: needinfo?(ying.xu)
Ying,

Please ni? me when your master patch is ready. I will try to find reviewer for you.
Flags: needinfo?(ying.xu)
Attached file PR@master
Attachment #8459413 - Flags: review?(21)
Flags: needinfo?(ying.xu)
Attachment #8459413 - Flags: review?(21) → review?(crdlc)
Comment on attachment 8459413 [details] [review]
PR@master

LGTM, please address a comment in github
Attachment #8459413 - Flags: review?(crdlc) → review+
updated code as comment11

 function goToPage(index, callback) {
- if (index < 0 || index >= pages.length)
+ if (index < 0 || index >= pages.length) {
+ if (callback) {
+ setTimeout(callback, 0);
+ }
return;
+ }
Minor issue and remove the noms for now.
blocking-b2g: 1.4? → ---
Mass update: Resolve wontfix all issues with legacy homescreens.

As of 2.6 we have a new homescreen and having these issues open is confusing. All issues will block bug 1231115 so we can use that to re-visit any of these if needed.
Blocks: 1231115
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.