Failed to build B2G desktop with MOZ_B2G_RIL enabled, "Reference-counted class IccManager should not have a public destructor"

RESOLVED FIXED in 2.0 S6 (18july)

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vicamo, Assigned: vicamo)

Tracking

unspecified
2.0 S6 (18july)
x86_64
macOS
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [p=1])

Attachments

(1 attachment)

+++ This bug was initially created as a clone of Bug #1035394 +++

This is a follow-up of bug 1028588, which added such detection to much of nsISupportsImpl.h but left out _INHERITED macros.
This patch either adds a private dummy dtor to RIL ref-counted components or move their public dtor to private section.
Attachment #8453737 - Flags: review?(htsai)
OS: Gonk (Firefox OS) → Mac OS X
Whiteboard: [p=1]
Comment on attachment 8453737 [details] [diff] [review]
bug-1035394.patch

Review of attachment 8453737 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you.
Attachment #8453737 - Flags: review?(htsai) → review+
https://hg.mozilla.org/mozilla-central/rev/d90e710df0c8
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S6 (18july)
Any particular reason why an extra private has been inserted in numerous files e.g. http://hg.mozilla.org/mozilla-central/diff/d90e710df0c8/dom/icc/src/IccListener.h
(In reply to Ian Neal from comment #6)
> Any particular reason why an extra private has been inserted in numerous
> files e.g.
> http://hg.mozilla.org/mozilla-central/diff/d90e710df0c8/dom/icc/src/
> IccListener.h

When compiled on Mac or any other platform with MOZ_IS_DESTRUCTIBLE turned on, it fails to when some ref-counted class has explicit or implicit dtor.
You need to log in before you can comment on or make changes to this bug.