1036877 - Failed to build B2G desktop with MOZ_B2G_RIL enabled, "Reference-counted class IccManager should not have a public destructor"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

+++ This bug was initially created as a clone of Bug #1035394 +++

This is a follow-up of bug 1028588, which added such detection to much of nsISupportsImpl.h but left out _INHERITED macros.

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

Attachment: bug-1035394.patch

This patch either adds a private dummy dtor to RIL ref-counted components or move their public dtor to private section.

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

try all: https://tbpl.mozilla.org/?tree=Try&rev=cbdf5d73c6ce

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8453737 [details] [diff] [review]
bug-1035394.patch

Review of attachment 8453737 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you.

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/integration/b2g-inbound/rev/d90e710df0c8

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d90e710df0c8

Comment 6

[Ian Neal]

Any particular reason why an extra private has been inserted in numerous files e.g. http://hg.mozilla.org/mozilla-central/diff/d90e710df0c8/dom/icc/src/IccListener.h

Comment 7

[Vicamo Yang [:vicamo][:vyang]]

(In reply to Ian Neal from comment #6)
> Any particular reason why an extra private has been inserted in numerous
> files e.g.
> http://hg.mozilla.org/mozilla-central/diff/d90e710df0c8/dom/icc/src/
> IccListener.h

When compiled on Mac or any other platform with MOZ_IS_DESTRUCTIBLE turned on, it fails to when some ref-counted class has explicit or implicit dtor.