Closed Bug 1036955 Opened 6 years ago Closed 2 years ago

Unit tests should not pass when we have as JS error

Categories

(Firefox OS Graveyard :: Gaia::TestAgent, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: rik, Unassigned)

Details

With the patch in bug 1027471 applied, we discovered that our unit tests stayed green even though there was a JS error (see bug 1036378)

Here are the errors:
JavaScript error: app://system.gaiamobile.org/test/unit/app_install_manager_test.js?time=1404908206512, line 666: this.sinon is undefined
JavaScript error: app://system.gaiamobile.org/js/app_install_manager.js?time=1404908206692, line 16: SystemBanner is not a constructor

Without the error, we have:
195 passing (6s)
With the error, we have:
28 passing (600ms)
Would you have the time to see if the patch in bug 874510 fixes this?
Flags: needinfo?(anthony)
I just tested and it doesn't fix it.
Flags: needinfo?(anthony)
Ok

I think the next step is to make a simple test case for this issue to see if this works with plain mocha in browser or even in node. If plain mocha has this issue then we'll report to them, otherwise we'll fix in test-agent.
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.