Closed Bug 1036957 Opened 5 years ago Closed 5 years ago

Remove --type's default value from Marionette runner

Categories

(Testing :: Marionette, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla34

People

(Reporter: zcampbell, Assigned: Bebe)

Details

(Whiteboard: [affects=b2g])

Attachments

(1 file, 1 obsolete file)

The --type argument has a default of "browser+b2g" which ties users of the runner into this being their default.

http://dxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/runner/base.py#406

If we could remove this and allow the defaults to be picked up from the manifest files themselves the test suites would have more relevant default values.
Whiteboard: [affects=b2g]
I can give this a try

Except of removing the default value do we need to update anything else?
Assignee: nobody → florin.strugariu
Flags: needinfo?(mdas)
Comment on attachment 8478917 [details] [diff] [review]
0001-Bug-1036957-Remove-type-s-default-value-from-Marione.patch

Review of attachment 8478917 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, thanks
Attachment #8478917 - Flags: review?(mdas) → review+
Flags: needinfo?(mdas)
Updated review message
Attachment #8478917 - Attachment is obsolete: true
adding checkin-needed as I only changed the commit message
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e89cb1dbd13f
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.