1036957 - Remove --type's default value from Marionette runner

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Zac C (:zac)]

The --type argument has a default of "browser+b2g" which ties users of the runner into this being their default.

http://dxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/runner/base.py#406

If we could remove this and allow the defaults to be picked up from the manifest files themselves the test suites would have more relevant default values.

Comment 1

[Florin Strugariu [:Bebe]]

I can give this a try

Except of removing the default value do we need to update anything else?

Comment 2

[Florin Strugariu [:Bebe]]

Attachment: 0001-Bug-1036957-Remove-type-s-default-value-from-Marione.patch

Comment 3

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 8478917 [details] [diff] [review]
0001-Bug-1036957-Remove-type-s-default-value-from-Marione.patch

Review of attachment 8478917 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, thanks

Comment 4

[Florin Strugariu [:Bebe]]

Attachment: 0001-Bug-1036957-Remove-type-s-default-value-from-Marione.patch

Updated review message

Comment 5

[Florin Strugariu [:Bebe]]

adding checkin-needed as I only changed the commit message

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e89cb1dbd13f

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e89cb1dbd13f