Closed Bug 1036977 Opened 10 years ago Closed 10 years ago

[Bluetooth] Port bug 1029387 to bluedroid2

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.0 S6 (18july)

People

(Reporter: tzimmermann, Assigned: tzimmermann)

References

Details

Attachments

(7 files, 2 obsolete files)

2.75 KB, patch
ben.tian
: review+
Details | Diff | Splinter Review
7.36 KB, patch
ben.tian
: review+
Details | Diff | Splinter Review
7.61 KB, patch
ben.tian
: review+
Details | Diff | Splinter Review
12.40 KB, patch
ben.tian
: review+
Details | Diff | Splinter Review
12.88 KB, patch
ben.tian
: review+
Details | Diff | Splinter Review
21.49 KB, patch
ben.tian
: review+
Details | Diff | Splinter Review
10.91 KB, patch
tzimmermann
: review+
Details | Diff | Splinter Review
      No description provided.
Depends on: 1029387
Hi Ben,

These are the same patches as in bug 1029387 for the current Bluetooth module. No changes except some rebasing.
Changes since v2

  - include <errno.h> and <unistd.h> in BluetoothInterface.cpp (see bug 986314)
Attachment #8454333 - Attachment is obsolete: true
Attachment #8454333 - Flags: review?(btian)
Attachment #8455256 - Flags: review?(btian)
Comment on attachment 8454330 [details] [diff] [review]
[02] Bug 1036977: Convert Bluedroid Socket's Listen method to asynchronous design (under bluetooth2/)

Review of attachment 8454330 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8454330 - Flags: review?(btian) → review+
Comment on attachment 8454328 [details] [diff] [review]
[01] Bug 1036977: Add result handler for Bluetooth Socket interface (under bluetooth2/)

Review of attachment 8454328 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8454328 - Flags: review?(btian) → review+
Comment on attachment 8454331 [details] [diff] [review]
[03] Bug 1036977: Convert Bluedroid Socket's Connect method to asynchronous design (under bluetooth2/)

Review of attachment 8454331 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8454331 - Flags: review?(btian) → review+
Comment on attachment 8454332 [details] [diff] [review]
[04] Bug 1036977: Introduce connection status for Bluedroid sockets (under bluetooth2/)

Review of attachment 8454332 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8454332 - Flags: review?(btian) → review+
Comment on attachment 8455256 [details] [diff] [review]
[05] Bug 1036977: Handle socket setup for |Connect| in BluetoothInterface (under bluetooth2/) (v2)

Review of attachment 8455256 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8455256 - Flags: review?(btian) → review+
Comment on attachment 8454334 [details] [diff] [review]
[06] Bug 1036977: Handle socket setup for |Accept| in BluetoothInterface (under bluetooth2/)

Review of attachment 8454334 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nit addressed.

::: dom/bluetooth2/bluedroid/BluetoothInterface.cpp
@@ +505,5 @@
>                                      -1, EmptyString(), 0, status);
>    }
>  }
>  
> +/* Specializes SocketMessageWatcher for Accept operations by

nit: |AcceptWatcher| specializes ...
Attachment #8454334 - Flags: review?(btian) → review+
Comment on attachment 8454335 [details] [diff] [review]
[07] Bug 1036977: Remove socket setup from BluetoothSocket (under bluetooth2/)

Review of attachment 8454335 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8454335 - Flags: review?(btian) → review+
Blocks: 1019376
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: