Closed
Bug 1036977
Opened 11 years ago
Closed 11 years ago
[Bluetooth] Port bug 1029387 to bluedroid2
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.0 S6 (18july)
People
(Reporter: tzimmermann, Assigned: tzimmermann)
References
Details
Attachments
(7 files, 2 obsolete files)
|
2.75 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
|
7.36 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
|
7.61 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
|
12.40 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
|
12.88 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
|
21.49 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
|
10.91 KB,
patch
|
tzimmermann
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8454328 -
Flags: review?(btian)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #8454330 -
Flags: review?(btian)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Attachment #8454331 -
Flags: review?(btian)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #8454332 -
Flags: review?(btian)
|
|
Assignee | |
Comment 5•11 years ago
|
||
Attachment #8454333 -
Flags: review?(btian)
|
|
Assignee | |
Comment 6•11 years ago
|
||
Attachment #8454334 -
Flags: review?(btian)
|
|
Assignee | |
Comment 7•11 years ago
|
||
Attachment #8454335 -
Flags: review?(btian)
|
|
Assignee | |
Comment 8•11 years ago
|
||
Hi Ben,
These are the same patches as in bug 1029387 for the current Bluetooth module. No changes except some rebasing.
|
|
Assignee | |
Comment 9•11 years ago
|
||
Changes since v2
- include <errno.h> and <unistd.h> in BluetoothInterface.cpp (see bug 986314)
Attachment #8454333 -
Attachment is obsolete: true
Attachment #8454333 -
Flags: review?(btian)
Attachment #8455256 -
Flags: review?(btian)
|
||
Comment 10•11 years ago
|
||
Comment on attachment 8454330 [details] [diff] [review]
[02] Bug 1036977: Convert Bluedroid Socket's Listen method to asynchronous design (under bluetooth2/)
Review of attachment 8454330 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM.
Attachment #8454330 -
Flags: review?(btian) → review+
|
|
||
Comment 11•11 years ago
|
||
Comment on attachment 8454328 [details] [diff] [review]
[01] Bug 1036977: Add result handler for Bluetooth Socket interface (under bluetooth2/)
Review of attachment 8454328 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM.
Attachment #8454328 -
Flags: review?(btian) → review+
|
|
||
Comment 12•11 years ago
|
||
Comment on attachment 8454331 [details] [diff] [review]
[03] Bug 1036977: Convert Bluedroid Socket's Connect method to asynchronous design (under bluetooth2/)
Review of attachment 8454331 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM.
Attachment #8454331 -
Flags: review?(btian) → review+
|
|
||
Comment 13•11 years ago
|
||
Comment on attachment 8454332 [details] [diff] [review]
[04] Bug 1036977: Introduce connection status for Bluedroid sockets (under bluetooth2/)
Review of attachment 8454332 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM.
Attachment #8454332 -
Flags: review?(btian) → review+
|
|
||
Comment 14•11 years ago
|
||
Comment on attachment 8455256 [details] [diff] [review]
[05] Bug 1036977: Handle socket setup for |Connect| in BluetoothInterface (under bluetooth2/) (v2)
Review of attachment 8455256 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM.
Attachment #8455256 -
Flags: review?(btian) → review+
|
|
||
Comment 15•11 years ago
|
||
Comment on attachment 8454334 [details] [diff] [review]
[06] Bug 1036977: Handle socket setup for |Accept| in BluetoothInterface (under bluetooth2/)
Review of attachment 8454334 [details] [diff] [review]:
-----------------------------------------------------------------
r=me with nit addressed.
::: dom/bluetooth2/bluedroid/BluetoothInterface.cpp
@@ +505,5 @@
> -1, EmptyString(), 0, status);
> }
> }
>
> +/* Specializes SocketMessageWatcher for Accept operations by
nit: |AcceptWatcher| specializes ...
Attachment #8454334 -
Flags: review?(btian) → review+
|
|
||
Comment 16•11 years ago
|
||
Comment on attachment 8454335 [details] [diff] [review]
[07] Bug 1036977: Remove socket setup from BluetoothSocket (under bluetooth2/)
Review of attachment 8454335 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM.
Attachment #8454335 -
Flags: review?(btian) → review+
|
|
Assignee | |
Comment 17•11 years ago
|
||
Changes since v1:
- updated comment
Attachment #8454334 -
Attachment is obsolete: true
Attachment #8456718 -
Flags: review+
|
|
Assignee | |
Comment 18•11 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/50fe2ac159df
https://hg.mozilla.org/integration/b2g-inbound/rev/13fce7913cc4
https://hg.mozilla.org/integration/b2g-inbound/rev/1f9016933323
https://hg.mozilla.org/integration/b2g-inbound/rev/b709235dd6b7
https://hg.mozilla.org/integration/b2g-inbound/rev/bea73261c792
https://hg.mozilla.org/integration/b2g-inbound/rev/60eabd556f3b
https://hg.mozilla.org/integration/b2g-inbound/rev/8a61cf67dd41
https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=8a61cf67dd41
https://hg.mozilla.org/mozilla-central/rev/50fe2ac159df
https://hg.mozilla.org/mozilla-central/rev/13fce7913cc4
https://hg.mozilla.org/mozilla-central/rev/1f9016933323
https://hg.mozilla.org/mozilla-central/rev/b709235dd6b7
https://hg.mozilla.org/mozilla-central/rev/bea73261c792
https://hg.mozilla.org/mozilla-central/rev/60eabd556f3b
https://hg.mozilla.org/mozilla-central/rev/8a61cf67dd41
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S6 (18july)
You need to log in
before you can comment on or make changes to this bug.
Description
•