Closed Bug 1036978 Opened 8 years ago Closed 5 years ago

Localization of un-used toolkit strings shouldn't be reported by compare-locales

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect)

x86
macOS
defect
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: Pike, Assigned: delphine, Mentored)

Details

Attachments

(2 files)

compare-locales currently reports all of toolkit for fennec, but it should just report the stuff that we're actually shipping.

The fix here is to make the two filter.py files in mobile match with what's in mobile/android/locales/jar.mn.
I'll look into this fix, with Axel's mentorship.
Assignee: nobody → jbeatty
Attachment #8471626 - Flags: review?(l10n)
Tested patch locally with compare-locales against xh, and compared output between local compare-locales and l.m.o compare locales. This patch appears to solve the problem.
Comment on attachment 8471626 [details] [diff] [review]
fennec-compare.patch

Review of attachment 8471626 [details] [diff] [review]:
-----------------------------------------------------------------

So yeah, this shouldn't work ;-)

I expect mod to be "dom", and path to be "chrome/global.dtd", when calling filter.py.

You can try with inserting a
  print mod, path
in filter py, just to get a feel. Or 
  import pdb; pdb.set_trace()

That'll get you in the debugger each time the function's called.
Attachment #8471626 - Flags: review?(l10n) → review-
Assignee: jbeatty → lebedel.delphine
Comment on attachment 8853353 [details]
Bug 1036978 - Localization of un-used toolkit strings shouldn't be reported by compare-locales,

https://reviewboard.mozilla.org/r/125468/#review127990
Attachment #8853353 - Flags: review?(l10n) → review+
Pushed by axel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f6c5fe557421
Localization of un-used toolkit strings shouldn't be reported by compare-locales, r=Pike
https://hg.mozilla.org/mozilla-central/rev/f6c5fe557421
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Gathered some data on central:

We overreported a total of 2981 strings on central, I expect that to be more on aurora still. Per locale on central, that's:

ar 599
ca 29
cs 6
da 6
de 29
es-AR 10
es-ES 8
et 10
eu 10
fa 587
fi 9
fr 0
fy-NL 6
ga-IE 6
gd 11
gl 264
he 223
hu 15
id 10
it 0
ja 10
ko 10
lt 10
nb-NO 10
nl 6
nn-NO 6
pa-IN 55
pl 0
pt-BR 8
pt-PT 6
ro 564
ru 0
sk 10
sl 10
sq 13
sr 6
sv-SE 6
th 380
tr 15
uk 6
zh-CN 6
zh-TW 6
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 55 → mozilla55
You need to log in before you can comment on or make changes to this bug.