1036978 - Localization of un-used toolkit strings shouldn't be reported by compare-locales

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Axel Hecht [:Pike]]

compare-locales currently reports all of toolkit for fennec, but it should just report the stuff that we're actually shipping.

The fix here is to make the two filter.py files in mobile match with what's in mobile/android/locales/jar.mn.

Comment 1

[Jeff Beatty [:gueroJeff]]

I'll look into this fix, with Axel's mentorship.

Comment 2

[Jeff Beatty [:gueroJeff]]

Attachment: fennec-compare.patch

Comment 3

[Jeff Beatty [:gueroJeff]]

Tested patch locally with compare-locales against xh, and compared output between local compare-locales and l.m.o compare locales. This patch appears to solve the problem.

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 8471626 [details] [diff] [review]
fennec-compare.patch

Review of attachment 8471626 [details] [diff] [review]:
-----------------------------------------------------------------

So yeah, this shouldn't work ;-)

I expect mod to be "dom", and path to be "chrome/global.dtd", when calling filter.py.

You can try with inserting a
  print mod, path
in filter py, just to get a feel. Or 
  import pdb; pdb.set_trace()

That'll get you in the debugger each time the function's called.

Comment 5

[Delphine Lebédel [:delphine - Use needinfo]]

Attachment: Bug 1036978 - Localization of un-used toolkit strings shouldn't be reported by compare-locales,

Change filter_py to only report on toolkit files referenced in
mobile/locales/jar.mn.

We ignore netwerk, security/manager, devtools/shared, services/sync
on the module level.

Review commit: https://reviewboard.mozilla.org/r/125468/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125468/

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 8853353 [details]
Bug 1036978 - Localization of un-used toolkit strings shouldn't be reported by compare-locales,

https://reviewboard.mozilla.org/r/125468/#review127990

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6c5fe557421
Localization of un-used toolkit strings shouldn't be reported by compare-locales, r=Pike

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f6c5fe557421

Comment 9

[Axel Hecht [:Pike]]

Gathered some data on central:

We overreported a total of 2981 strings on central, I expect that to be more on aurora still. Per locale on central, that's:

ar 599
ca 29
cs 6
da 6
de 29
es-AR 10
es-ES 8
et 10
eu 10
fa 587
fi 9
fr 0
fy-NL 6
ga-IE 6
gd 11
gl 264
he 223
hu 15
id 10
it 0
ja 10
ko 10
lt 10
nb-NO 10
nl 6
nn-NO 6
pa-IN 55
pl 0
pt-BR 8
pt-PT 6
ro 564
ru 0
sk 10
sl 10
sq 13
sr 6
sv-SE 6
th 380
tr 15
uk 6
zh-CN 6
zh-TW 6