1037027 - [Lockscreen] notifications can overlap the date on the lockscreen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: 2014-07-10-10-05-02.png

1. turn lock screen on
2. hit the power button twice
3. hit the screenshot buttons ( power + home for 2.0 ; power + volume down for 2.1) 5 times
4. pan a little bit on the notifications

Expected: no overlap with the date
Actual: overlap with the date

Note: regression : bug 836569
Gaia      09642e74e250fbc62db860c808ef188628fca55d
Gecko     https://hg.mozilla.org/mozilla-central/rev/f93c0ef45597
BuildID   20140710071928
Version   33.0a1
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
B1TC00011220

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: 2014-07-10-13-08-41.png

2.1 is bad.  See first attachment.
2.0 there's a slight overlap at the bottom.  See second attachment

Gaia      35a9b715e7348ec738ff6c8a59f50190390a06f2
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/94714370dfc3
BuildID   20140710000201
Version   32.0a2
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
B1TC00011220
Flame

Comment 2

[Jason Smith [:jsmith]]

QA Wanted for branch checks.

Comment 3

[howie [:howie]]

Assign to Greg now.

Comment 4

[Cody Roesch [:croesch]]

Requirement: 2 SIM cards must be present for this bug to occur. 

This bug repro's on: Flame 2.1 Master, Flame 2.0

Actual Results: With 2 SIM cards present, It's possible to get notifications to appear over the date on the lockscreen.

Environmental Variables:
Device: Flame Master
Build ID: 20140711062012
Gaia: c47094a26c87ba71a3da4bae54febd0da21f3393
Gecko: 75f66f8cb99f
Version: 33.0a1 (Master)
Firmware Version: v122
-----------------------------------------------
Environmental Variables:
Device: Flame 2.0
BuildID: 20140710213213
Gaia: 18c44a1bc31b374ba00a069904465a8d07971a60
Gecko: f880dae4fdbe
Version: 32.0a2 (2.0) 
Firmware Version: v122

-----------------------------------------------
-----------------------------------------------

This bug does NOT repro on: Flame 1.4

Actual Result: With 2 SIM cards in the device, the notifications on the lock screen do not overlap the date.

Environmental Variables:
Device: Flame 1.4
Build ID: 20140711075012
Gaia: c78d1ab13586da4db62690fab915cf8256d09c35
Gecko: 2b648cedfc83
Version: 30.0 (1.4)
Firmware Version: v122

Comment 5

[Cody Roesch [:croesch]]

Maybe the title should reflect that 2 SIM cards are needed for this bug to occur?

Comment 6

[Joshua Mitchell (Inactive)]

Comment 0 already identifies the cause: regression : bug 836569
window not needed.

Comment 7

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

While I don't do anything but change one digit, CSS linter is harsh to me. So I add one line fix in the xfail.

Comment 8

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: 2014-07-14-02-02-54.png

After I applied the patch.

Comment 9

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/2038b76e5bd4632d12944f9b3d835314fec9de39

Will close after I submit and merge v2.0 patch.

Comment 10

[Greg Weng [:snowmantw][:gweng][:λ]]

v2.0 https://github.com/mozilla-b2g/gaia/commit/2038b76e5bd4632d12944f9b3d835314fec9de39

Comment 11

[Ryan VanderMeulen [:RyanVM]]

(In reply to Greg Weng [:snowmantw][:gweng][:λ] from comment #9)
> Will close after I submit and merge v2.0 patch.

Bug resolution tracks landing on trunk/master. Status flags track uplifts. Please follow standard practices as many other processes expect it :)

Comment 12

[Shine(Leave from Mozilla)]

Attachment: video

This issue has been verified successfully on Flame 2.0 and 2.1
See attachment: Verify_1037027.MP4
Reproducing rate: 0/5
Flame 2.0 build:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141130000204
Version         32.0

Flame 2.1 build:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141130001203
Version         34.0