Closed Bug 1037051 Opened 10 years ago Closed 10 years ago

NFC Event callback handling cleanup

Categories

(Firefox OS Graveyard :: NFC, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID
2.0 S6 (18july)

People

(Reporter: dgarnerlee, Assigned: dgarnerlee)

References

Details

Attachments

(1 file)

The NFC event handling in the parent process tries to minimally validate the assigned event ID (content or parent origin) before further processing. These event IDs doesn't need to be a bit field at all, since getEventType on the mozNFC DOM is doing the event name to id mapping.
Blocks: 1034405
Assignee: nobody → dgarnerlee
blocking-b2g: --- → 2.0?
Small cleanup for event matching (do not allow multiple events IDs in one event). Setup for new events to be added. This does not rename the eventmap names and such.
blocking as this is needed by 1034405
blocking-b2g: 2.0? → 2.0+
Attachment #8453962 - Flags: review?(allstars.chh)
Comment on attachment 8453962 [details] [diff] [review]
0001-Bug-1037051-NFC-Event-callback-handling-cleanup.patch

Review of attachment 8453962 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry I don't know what you're trying to fix here,
And I don't undertstand why this blocks Bug 1034405.
Attachment #8453962 - Flags: review?(allstars.chh)
(In reply to Yoshi Huang[:allstars.chh] from comment #4)
> Comment on attachment 8453962 [details] [diff] [review]
> 0001-Bug-1037051-NFC-Event-callback-handling-cleanup.patch
> 
> Review of attachment 8453962 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Sorry I don't know what you're trying to fix here,
> And I don't undertstand why this blocks Bug 1034405.

https://bugzilla.mozilla.org/show_bug.cgi?id=1034405#c7
https://bugzilla.mozilla.org/show_bug.cgi?id=1034405#c11
Refer to comments from above links, this event callback handling at gecko side is for fixing bug 1034405.
Target Milestone: --- → 2.0 S6 (18july)
(In reply to Wesley Huang [:wesley_huang] from comment #5)
> https://bugzilla.mozilla.org/show_bug.cgi?id=1034405#c7
> https://bugzilla.mozilla.org/show_bug.cgi?id=1034405#c11
> Refer to comments from above links, this event callback handling at gecko
> side is for fixing bug 1034405.

I do check comments on Bug 1034405 before and I don't think he's trying to fix the right problem, or even if he is, he needs to explain it clearly.

By looking into his patch I didn't any problem for the existing code and I have no idea what he is doing.
Hi folks, can we have an estimate for this bug? This is the last week for landing 2.0 bugs and we have a gaia patch pending from this bug.

Thanks!
(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #7)
> Hi folks, can we have an estimate for this bug? This is the last week for
> landing 2.0 bugs and we have a gaia patch pending from this bug.
> 
> Thanks!

I'll recheck after a repo sync to see if the stale gecko object message comes up again. The contacts app has a lazy loaded callback definition. If not, I'll unblock it.
Unblocking Bug 1034405, since it's not actually fixing the stale content side mozNFCPeer object in that bug.
No longer blocks: 1034405
(In reply to Yoshi Huang[:allstars.chh] from comment #6)
> By looking into his patch I didn't any problem for the existing code and I
> have no idea what he is doing.

At this point, it's just a cleanup patch for allowing additional events (the events could just be fired separately).
blocking-b2g: 2.0+ → ---
Please rebase and see your problem still exists.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: