1037120 - Clean up code data reporting notification code from bug 981689

Status: RESOLVED WORKSFORME

(Firefox Health Report Graveyard :: Client: Desktop, defect, P4)

Description

[Gregory Szorc [:gps]]

Bug 981689 changed some code around the data reporting notification.

As part of reviewing bug 862563, I found some code paths that lead to unexploded ordinance in the tree. For example, I /think/ that we'll get a perma orange on beta following an uplift. This is due to the way the implementation in bug 981689 is consulting channel-specific preferences. Essentially there are tests expecting certain values and those assumptions are wrong as soon as we hit beta.

Also, the test added in bug 981689, as gfritsche discovered, is testing some suspect behavior.

Comment 1

[Benjamin Smedberg]

Bug 981689 is already in beta (31).

Comment 2

[Gregory Szorc [:gps]]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #1)
> Bug 981689 is already in beta (31).

I'm worried about the next bump to the version number. We should have used a channel pref override as opposed to separate preferences, among other things. See the comments from rnewman and me in that bug.

There's also a few hard-coded references to version numbers in places. This will make policy version bumps difficult and prone to footgunning. Given the importance of this code (possibly even legal importance), it needs cleaning.

Comment 3

[Georg Fritzsche [:gfritzsche]]

Bug 1239480 already dealt with train jumping failures, but we should investigate whether the comments on rewriting the prefs are still relevant.

Comment 4

[Georg Fritzsche [:gfritzsche]]

The data reporting notification code changed substantially since this was filed.
Closing this, we can file new bugs for any current issues.