1037171 - Find my device is enabled on FXA login when fmd login is cancelled

Status: VERIFIED FIXED

(Firefox OS Graveyard :: FindMyDevice, defect)

Description

[Mark Goodwin [:mgoodwin]]

STR:
1) go to settings -> find my device
2) Click 'create an account or sign in'
3) cancel (using the X at top left)
4) Go to FXA in settings
5) login
6) observe FMD is now enabled.

Comment 1

[Mark Goodwin [:mgoodwin]]

ggp, surely we don't need oncancel for this?

onerror is fired when a user cancels anyway, and if we have an error case the user will need to click 'login' again anyway, so we can just reset _interactiveLogin on error, right?

Comment 2

[Guilherme Gonçalves [:ggp]]

That's correct, and that's how I hacked around it yesterday. However, the fact that onerror fires is a bug in FxA's API; the correct behavior would have been for oncancel to fire. So once they fix it we'll still need to handle oncancel, as I expect that onerror will stop firing then. It won't hurt to reset _interactiveLogin on error as well, I think.

Comment 3

[Mark Goodwin [:mgoodwin]]

OK; I'll ensure we address both of these cases.

Comment 4

[vkrishnamoorthy]

From a product perspective, I recommend we block on this as FMD is enabled with out direct user action. Please 2.0+ this

Comment 5

[bhavana bajaj [:bajaj]]

can we get this added to moztrap as well ?

Comment 6

[Kate Glazko]

Yes, this can be added today. Is this going to be a user story? Should I add it to the functional test run?

Comment 7

[Mark Goodwin [:mgoodwin]]

Attachment: Ensure FMD is not automatically enabled after cancellation or error

Comment 8

[vkrishnamoorthy]

(In reply to kglazko from comment #6)
> Yes, this can be added today. Is this going to be a user story? Should I add
> it to the functional test run?

This is not a user story

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8455240 [details] [review]
Ensure FMD is not automatically enabled after cancellation or error

Thanks for the patch. r=me with the nits addressed.

Comment 10

[Mark Goodwin [:mgoodwin]]

(In reply to Arthur Chen [:arthurcc] from comment #9)
> Thanks for the patch. r=me with the nits addressed.

Nits addressed. Many thanks.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/827d37c5ad73ba232ca5e3c51a2b512287fc55b5

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/bc8af54dd40e8d3ffbb49099dc6fc760d5406055

Comment 13

[Shine(Leave from Mozilla)]

Attachment: video

This issue has been verified successfully on Flame 2.0 and 2.1
See attachment: Verify_ 1037171.MP4
Reproducing rate: 0/5
Flame 2.0 build:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141130000204
Version         32.0

Flame 2.1 build:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141130001203
Version         34.0

Comment 14

[Mark Goodwin [:mgoodwin]]

I'm not going to have time to look at this for the next few weeks; can you take a look?

Comment 15

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Hi Mark - Looks verified to me, I think we're good here. ^_^