Closed Bug 1037171 Opened 5 years ago Closed 5 years ago
Find my device is enabled on FXA login when fmd login is cancelled
STR: 1) go to settings -> find my device 2) Click 'create an account or sign in' 3) cancel (using the X at top left) 4) Go to FXA in settings 5) login 6) observe FMD is now enabled.
blocking-b2g: --- → 2.0?
Target Milestone: --- → 2.0 S6 (18july)
ggp, surely we don't need oncancel for this? onerror is fired when a user cancels anyway, and if we have an error case the user will need to click 'login' again anyway, so we can just reset _interactiveLogin on error, right?
That's correct, and that's how I hacked around it yesterday. However, the fact that onerror fires is a bug in FxA's API; the correct behavior would have been for oncancel to fire. So once they fix it we'll still need to handle oncancel, as I expect that onerror will stop firing then. It won't hurt to reset _interactiveLogin on error as well, I think.
OK; I'll ensure we address both of these cases.
From a product perspective, I recommend we block on this as FMD is enabled with out direct user action. Please 2.0+ this
can we get this added to moztrap as well ?
Yes, this can be added today. Is this going to be a user story? Should I add it to the functional test run?
(In reply to kglazko from comment #6) > Yes, this can be added today. Is this going to be a user story? Should I add > it to the functional test run? This is not a user story
Comment on attachment 8455240 [details] [review] Ensure FMD is not automatically enabled after cancellation or error Thanks for the patch. r=me with the nits addressed.
Attachment #8455240 - Flags: review?(arthur.chen) → review+
(In reply to Arthur Chen [:arthurcc] from comment #9) > Thanks for the patch. r=me with the nits addressed. Nits addressed. Many thanks.
This issue has been verified successfully on Flame 2.0 and 2.1 See attachment: Verify_ 1037171.MP4 Reproducing rate: 0/5 Flame 2.0 build: Gaia-Rev 8d1e868864c8a8f1e037685f0656d1da70d08c06 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3 Build-ID 20141130000204 Version 32.0 Flame 2.1 build: Gaia-Rev ccb49abe412c978a4045f0c75abff534372716c4 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22 Build-ID 20141130001203 Version 34.0
I'm not going to have time to look at this for the next few weeks; can you take a look?
Assignee: mgoodwin → nobody
Hi Mark - Looks verified to me, I think we're good here. ^_^
You need to log in before you can comment on or make changes to this bug.