1037228 - browser_download.js with "Found an unexpected alert:alert at the end of test run"

Status: RESOLVED FIXED

(Firefox Graveyard :: Webapp Runtime, defect, P1)

Description

[Myk Melez [:myk] [@mykmelez]]

The most recent Windows test runs on Cedar <https://tbpl.mozilla.org/?tree=Cedar&rev=6d6abdc64ea1> fail in browser_download.js with "Found an unexpected alert:alert at the end of test run" and sometimes also a leakcheck with many bytes and URLs leaked:

  https://tbpl.mozilla.org/php/getParsedLog.php?id=43314070&tree=Cedar
  https://tbpl.mozilla.org/php/getParsedLog.php?id=43318583&tree=Cedar
  https://tbpl.mozilla.org/php/getParsedLog.php?id=43323642&tree=Cedar

Marco: will bug 911636 fix this?

Comment 1

[Marco Castelluccio [:marco]]

Yes, this is going to be automatically fixed by bug 911636 (because we won't show an alert at the end of the download).
If we want to fix it before bug 911636, it should be just a matter of setting the "browser.download.manager.showAlertOnComplete" pref to false during the test.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Confirmed, the Windows runs on Cedar are now succeeding!  To wit:

https://tbpl.mozilla.org/php/getParsedLog.php?id=46367620&tree=Cedar
https://tbpl.mozilla.org/php/getParsedLog.php?id=46393311&tree=Cedar
https://tbpl.mozilla.org/php/getParsedLog.php?id=46367764&tree=Cedar
https://tbpl.mozilla.org/php/getParsedLog.php?id=46396524&tree=Cedar
https://tbpl.mozilla.org/php/getParsedLog.php?id=46367741&tree=Cedar

Comment 3

[Marco Castelluccio [:marco]]

Woot!