Closed Bug 1037266 Opened 10 years ago Closed 6 years ago

[email][l10n] push updated wrote/originalMessage/forwardHeaderLabels to back-end on language change/localized event

Categories

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: ehsan.akhgari, Unassigned)

Details

STR:

1. Set the system language to Arabic.
2. Open the Email app.
3. Switch to Settings and change the language back to English.
4. You'll see that part of the UI remains in Arabic (such as the window title) but the rest gets translated.
5. Reply to an email.  This text gets injected into the body of the email:


كتب {name } :

In Arabic, كتب means "wrote".  So this is the translated version of "wrote" staying Arabic after the language switch.

I don't know what causes the rest to be {name} though.
I think we have a bug covering re-propagating strings into the back-end, but the {name } thing is a bug/typo in the locale.  It needs to be {name} like in the english locale:
https://github.com/mozilla-b2g/gaia/blob/master/apps/email/locales/email.en-US.properties#L372
(In reply to Andrew Sutherland [:asuth] from comment #1)
> I think we have a bug covering re-propagating strings into the back-end, but
> the {name } thing is a bug/typo in the locale.  It needs to be {name} like
> in the english locale:
> https://github.com/mozilla-b2g/gaia/blob/master/apps/email/locales/email.en-
> US.properties#L372

You're right! <http://hg.mozilla.org/gaia-l10n/ar/file/912d6c9267d7/apps/email/email.properties#l374>
(In reply to :Ehsan Akhgari (lagging on bugmail, needinfo? me!) from comment #2)
> (In reply to Andrew Sutherland [:asuth] from comment #1)
> > I think we have a bug covering re-propagating strings into the back-end, but
> > the {name } thing is a bug/typo in the locale.  It needs to be {name} like
> > in the english locale:
> > https://github.com/mozilla-b2g/gaia/blob/master/apps/email/locales/email.en-
> > US.properties#L372
> 
> You're right!
> <http://hg.mozilla.org/gaia-l10n/ar/file/912d6c9267d7/apps/email/email.
> properties#l374>

Ehsan filed bug 1037529 on this.  Thanks, Ehsan!


I checked and it doesn't look like the other bugs cover this, so morphing this bug.

Basically, the call to api.useLocalizedStrings at https://github.com/mozilla-b2g/gaia/blob/master/apps/email/js/mail_app.js#L107 needs to be re-run when the language changes.

Note that the folder names are a somewhat separate issue and should be fixed on bug 855198 although it's fine if this bug ends up improving the situation as a side-effect.
Summary: Change of language invalidates the string autogenerated for replying to email → [email][l10n] push updated wrote/originalMessage/forwardHeaderLabels to back-end on language change/localized event
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.