Closed Bug 1037280 Opened 5 years ago Closed 5 years ago

Intermittent browser_inspector_update-on-navigation.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/devtools/framework/toolbox.xul]

Categories

(DevTools :: Inspector, defect)

x86_64
Linux
defect
Not set

Tracking

(firefox31 unaffected, firefox32 unaffected, firefox33 fixed, firefox-esr24 unaffected)

RESOLVED FIXED
Firefox 33
Tracking Status
firefox31 --- unaffected
firefox32 --- unaffected
firefox33 --- fixed
firefox-esr24 --- unaffected

People

(Reporter: RyanVM, Assigned: sjakthol)

Details

(Keywords: intermittent-failure, memory-leak)

Attachments

(1 file)

https://tbpl.mozilla.org/php/getParsedLog.php?id=43533315&tree=Mozilla-Inbound

Ubuntu VM 12.04 x64 mozilla-inbound debug test mochitest-devtools-chrome-1 on 2014-07-10 08:16:27 PDT for push a60165250783
slave: tst-linux64-spot-179

09:02:43  WARNING -  TEST-UNEXPECTED-FAIL | browser/devtools/inspector/test/browser_inspector_update-on-navigation.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/devtools/framework/toolbox.xul]
It appears that when the last test is executed the toolbox doesn't have enough time to destroy itself thus leaking a toolbox window.

This patch makes the cleanup function responsible for toolbox destruction a generator that yields until toolbox is destroyed. It should work as the test harness yields on the cleanup functions inside a task: https://mxr.mozilla.org/mozilla-central/source/testing/mochitest/browser-test.js#331

Pending try: https://tbpl.mozilla.org/?tree=Try&rev=d05a81940573

Locally got ~40 test runs without a leak on a linux64 debug build.
Assignee: nobody → sjakthol
Status: NEW → ASSIGNED
Attachment #8454311 - Flags: review?(pbrosset)
(In reply to Sami Jaktholm from comment #1)
> This patch makes the cleanup function responsible for toolbox destruction a
> generator that yields until toolbox is destroyed. It should work as the test
> harness yields on the cleanup functions inside a task:
> https://mxr.mozilla.org/mozilla-central/source/testing/mochitest/browser-
> test.js#331
Thanks for pointing that out, I had no idea, this might help a lot actually.
Attachment #8454311 - Flags: review?(pbrosset) → review+
https://hg.mozilla.org/mozilla-central/rev/48c77bd996de
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.