1037291 - Make BluetoothDiscoveryHandle expire when discovery is stopped

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Ben Tian (inactive)]

When adapter A gets a discovery handle from |startDiscovery|, prior discovery handles held by either adapter A or other adapters should expire and stop listening to "DeviceFound" bluetooth signal.

Comment 1

[Ben Tian (inactive)]

Attachment: Patch 1 (v1): Make BluetoothDiscoveryHandle expire when discovery is stopped

Also reject promise of startDiscovery when discovery is already started, in order to inform applications to get a new discovery handle from another startDiscovery call.

Comment 2

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 8454231 [details] [diff] [review]
Patch 1 (v1): Make BluetoothDiscoveryHandle expire when discovery is stopped

Review of attachment 8454231 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nit addressed.

::: dom/bluetooth2/BluetoothAdapter.cpp
@@ +400,5 @@
>  }
>  
> +void
> +BluetoothAdapter::SetDiscoveryHandleInUse(
> +  nsRefPtr<BluetoothDiscoveryHandle> aDiscoveryHandle)

nit: please do not pass a nsRefPtr as an argument since it's wasteful. 

https://developer.mozilla.org/en-US/docs/Using_nsCOMPtr/Getting_Started_Guide#nsCOMPtrs_in_function_signatures

Comment 3

[Ben Tian (inactive)]

Attachment: [final] Patch 1: Make BluetoothDiscoveryHandle expire when discovery is stopped, r=echou

Revise based on reviewer's comment.

Comment 4

[Ben Tian (inactive)]

https://hg.mozilla.org/integration/b2g-inbound/rev/c2ae38e66552

Comment 5

[Ben Tian (inactive)]

https://hg.mozilla.org/mozilla-central/rev/c2ae38e66552