Closed
Bug 1037337
Opened 12 years ago
Closed 12 years ago
[NFC] NfcManager cleanup, add jsdoc, add missing unit tests etc.
Categories
(Firefox OS Graveyard :: NFC, defect)
Tracking
(b2g-v2.1 fixed)
RESOLVED
FIXED
2.1 S2 (15aug)
| Tracking | Status | |
|---|---|---|
| b2g-v2.1 | --- | fixed |
People
(Reporter: tauzen, Assigned: tauzen)
References
Details
Attachments
(1 file)
Before implementing instantiable NfcManager (Bug 971520) additional cleanup is needed:
1. marking private methods with '_'
2. jsdoc
3. remaining unit tests
4. rethinking ndef parsing for purpose of activity launching - it seems that ndef_utils might be a good place to do this.
Points 3 and 4 might be done in separate bugs, depending on the complexity of changes.
|
Assignee | |
Updated•12 years ago
|
|
|
Assignee | |
Comment 1•12 years ago
|
||
Missing unit tests were introduced in Bug 1049566. NDEF parsing was moved to nfc_utils.js in Bug 1039245.
Changes in this patch:
1. using arrow function instead of var self = this
2. removed isScreenUnlockAndEnabled - not needed
3. added missing comments
4. marked private methods, properties with _
5. small refactoring
Greg could you review this?
Attachment #8472122 -
Flags: review?(gweng)
|
|
Assignee | |
Updated•12 years ago
|
Target Milestone: --- → 2.1 S2 (15aug)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8472122 [details] [review]
pull-request-1037337.txt
Great!
|
|
||
Updated•12 years ago
|
Attachment #8472122 -
Flags: review?(gweng) → review+
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
status-b2g-v2.1:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•