1037337 - [NFC] NfcManager cleanup, add jsdoc, add missing unit tests etc.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Krzysztof Mioduszewski[:tauzen]]

Before implementing instantiable NfcManager (Bug 971520) additional cleanup is needed:
1. marking private methods with '_'
2. jsdoc
3. remaining unit tests
4. rethinking ndef parsing for purpose of activity launching - it seems that ndef_utils might be a good place to do this.

Points 3 and 4 might be done in separate bugs, depending on the complexity of changes.

Comment 1

[Krzysztof Mioduszewski[:tauzen]]

Attachment: pull-request-1037337.txt

Missing unit tests were introduced in Bug 1049566. NDEF parsing was moved to nfc_utils.js in Bug 1039245.

Changes in this patch:
1. using arrow function instead of var self = this
2. removed isScreenUnlockAndEnabled - not needed
3. added missing comments
4. marked private methods, properties with _
5. small refactoring

Greg could you review this?

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8472122 [details] [review]
pull-request-1037337.txt

Great!

Comment 3

[Krzysztof Mioduszewski[:tauzen]]

Thanks for the review!

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/0e2277c7359d889f72eb623d05d63761ad4074e0