Closed Bug 1037339 Opened 6 years ago Closed 6 years ago

Update nsIHttpChannel.idl to reflect the changes of requestMethod property

Categories

(Core :: Networking: HTTP, defect)

x86_64
All
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: xyuan, Assigned: ryou)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 477578 changed nsIHttpChannel.requestMethod to be case sensitive from that of case insensitive.

We should update the comments of nsIHttpChannel.idl about this change:

http://mxr.mozilla.org/mozilla-central/source/netwerk/protocol/http/nsIHttpChannel.idl#27
Assignee: nobody → ryou
Attachment #8454322 - Flags: review?(hurley)
Attachment #8454322 - Attachment description: 0001-Bug-1037339-Update-nsIHttpChannel.idl-to-reflect-the.patch → Patch, update comments in nsIHttpChannel.idl
Comment on attachment 8454322 [details] [diff] [review]
Patch, update comments in nsIHttpChannel.idl

Review of attachment 8454322 [details] [diff] [review]:
-----------------------------------------------------------------

Please use more context on your patches in the future (at least 8 lines).
Attachment #8454322 - Flags: review?(hurley) → review+
(In reply to Nicholas Hurley [:hurley] from comment #2)
> Comment on attachment 8454322 [details] [diff] [review]
> Patch, update comments in nsIHttpChannel.idl
> 
> Review of attachment 8454322 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Please use more context on your patches in the future (at least 8 lines).

OK. Thanks for noticing.
Attachment #8454322 - Attachment is obsolete: true
Attachment #8456002 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c90fe92f7164
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.