1037339 - Update nsIHttpChannel.idl to reflect the changes of requestMethod property

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Yuan Xulei [:yxl] (Leave from May 18)]

Bug 477578 changed nsIHttpChannel.requestMethod to be case sensitive from that of case insensitive.

We should update the comments of nsIHttpChannel.idl about this change:

http://mxr.mozilla.org/mozilla-central/source/netwerk/protocol/http/nsIHttpChannel.idl#27

Comment 1

[Rui You [:ryou]]

Attachment: Patch, update comments in nsIHttpChannel.idl

Comment 2

[u408661]

Comment on attachment 8454322 [details] [diff] [review]
Patch, update comments in nsIHttpChannel.idl

Review of attachment 8454322 [details] [diff] [review]:
-----------------------------------------------------------------

Please use more context on your patches in the future (at least 8 lines).

Comment 3

[Rui You [:ryou]]

(In reply to Nicholas Hurley [:hurley] from comment #2)
> Comment on attachment 8454322 [details] [diff] [review]
> Patch, update comments in nsIHttpChannel.idl
> 
> Review of attachment 8454322 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Please use more context on your patches in the future (at least 8 lines).

OK. Thanks for noticing.

Comment 4

[Rui You [:ryou]]

Attachment: Patch, update comments in nsIHttpChannel.idl

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c90fe92f7164

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c90fe92f7164