Closed Bug 1037341 Opened 5 years ago Closed 5 years ago

Update pin and block with new icons

Categories

(Firefox :: New Tab Page, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 34
Iteration:
34.1
Tracking Status
firefox33 --- verified
firefox34 --- verified

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

Attachments

(3 files, 2 obsolete files)

Attached image wip screenshot
dcrobot's ui spec has new round buttons that are in the top-right corner of a tile.
Label for a pinned tiles should be Segoe UI, Negreta cursiva, 14 pixels, HEX = D0021B

Currently, it is not italicized.
Latest mockups have pin/block both at top corners as they were before.
Summary: Update pin and block with new icon and positioning → Update pin and block with new icons
Attached patch v1 (obsolete) — Splinter Review
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #8461256 - Flags: review?(adw)
Attachment #8461256 - Attachment description: bug1037341.patch → v1
Attached patch v1.1 (obsolete) — Splinter Review
Removed doctype per bug 1023655.
Attachment #8461256 - Attachment is obsolete: true
Attachment #8461256 - Flags: review?(adw)
Attachment #8461712 - Flags: review?(adw)
Excellent. Can we add 5 pixels between the tile and it's label?
Seems like svg + zoom/hidpi is working correctly
(In reply to Aaron from comment #5)
> Excellent. Can we add 5 pixels between the tile and it's label?
For this bug? It's not really related to the pin and block icons. Also, 5px lower would make it closer to the tile below it than the tile it's actually associated with. And increasing the spacing between tiles gets closer to making the default number of visible rows 2 for most users.
Blocks: 1037091
Comment on attachment 8461712 [details] [diff] [review]
v1.1

Review of attachment 8461712 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/newtab/newTab.inc.css
@@ +205,5 @@
>  
>  .newtab-control-sponsored {
> +  width: 24px;
> +  height: 24px;
> +  background-image: url(chrome://browser/skin/newtab/controls.png);

This should use controls@2x.png for 2x DPI, like it currently does, right?  r+ with that change, or let me know if I'm wrong.

It looks like .newtab-control-sponsored is the only thing left that uses controls[@2x].png.  Are there plans for that?  I think I saw somewhere it's going to be removed?
Attachment #8461712 - Flags: review?(adw) → review+
Attached patch for checkinSplinter Review
(In reply to Drew Willcoxon :adw from comment #8)
> Comment on attachment 8461712 [details] [diff] [review]
> ::: browser/themes/shared/newtab/newTab.inc.css
> >  .newtab-control-sponsored {
> > +  background-image: url(chrome://browser/skin/newtab/controls.png);
> This should use controls@2x.png for 2x DPI, like it currently does, right? 
> r+ with that change, or let me know if I'm wrong.
Indeed. Good catch! Added appropriate styling.
Attachment #8461712 - Attachment is obsolete: true
Blocks: 1040369
https://hg.mozilla.org/mozilla-central/rev/8f7aa126566d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Iteration: --- → 34.1
QA Whiteboard: [qa?]
Flags: firefox-backlog+
QA Whiteboard: [qa?] → [qa+]
QA Contact: cornel.ionce
Blocks: 1045751
Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.8.5 using latest Nightly 34.0a1 (buildID: 20140730030201).
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa+] → [qa!]
Blocks: 1057602
Uplift has been managed in bug 1057602
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:33.0) Gecko/20100101 Firefox/33.0
Mozilla/5.0 (X11; Linux i686; rv:33.0) Gecko/20100101 Firefox/33.0

Verified fixed on Windows 7 64bit, Mac OS X 10.8.5 and Ubuntu 14.04 32bit using latest Aurora, build ID: 20140828004002.
You need to log in before you can comment on or make changes to this bug.