Closed Bug 1037411 Opened 6 years ago Closed 6 years ago

Invert icons in the menubar in dark themes on Linux

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Points:
1

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 33
Iteration:
33.3

People

(Reporter: TeoVermesan, Assigned: dao)

References

Details

(Whiteboard: [testday-20140711])

Attachments

(2 files)

Screenshot from 2014-07-11 12:54:26.png
219.28 KB, image/png
Details
set appropriate text color for -moz-appearance: menubar
544 bytes, patch
Gijs
: review+
Details | Diff | Splinter Review 
Follow-up for Bug 994623:

Reproducible on:
latest Nightly: Build Identifier: 20140711030201
Mozilla/5.0 (X11; Linux x86_64; rv:33.0) Gecko/20100101 Firefox/33.0
latest Aurora: Build Identifier: 20140710004005
Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0 

Steps To Reproduce:
1. Move icons to tabstrip and menubar.

Expected results:
- The icons in the menu bar and tabstrip are white.

Actual results:
- The icons in the menu bar are almost invisible, while the icons in the tabstrip are white.
Please see attached screenshot.
QA Whiteboard: [testday-20140711]
Blocks: 994623
Summary: Invert icons in the menubar → Invert icons in the menubar in dark themes on Linux
Iteration: --- → 33.3
Points: --- → 1
Flags: firefox-backlog+
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #8454478 - Flags: review?(gijskruitbosch+bugs)
Added to Iteration 33.3
QA Whiteboard: [testday-20140711] → [qa?]
Whiteboard: [testday-20140711]
Attachment #8454478 - Flags: review?(gijskruitbosch+bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/3d74395f47e0
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Hi Dao, should this bug be marked as [qa+] or [qa-] for verification?
Flags: needinfo?(dao)
QA Whiteboard: [qa?] → [qa+]
Flags: needinfo?(dao)
Hi Florin, can a QA contact be assigned for verification of this bug.
Flags: needinfo?(florin.mezei)
Flags: needinfo?(florin.mezei)
QA Contact: teodora.vermesan
Icons in the menu bar and tabstrip are white, so:
verified as fixed on latest Nightly 33.0a1 (buildID: 20140715030207) under  Ubuntu 64bit.
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa+] → [qa!]
Depends on: 1083668
You need to log in before you can comment on or make changes to this bug.