1037436 - Coding Style Guide operator placement contradicts gecko-dev code base

Status: RESOLVED INVALID

(DevTools :: General, defect)

Description

[Adrian Aichner [:anaran]]

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Operators

recommends to put operators at the begin of continuations lines, not at end of previous line.

This is against current coding practice, as demonstrated by following commands.

/tmp/git.mozilla.org/gecko-dev$ grep -rE "^\s*[-+,:?]" --include=*.js browser | grep -vE ":\s*(\-\-|\+\+)" | wc
   1091    5472  104753
/tmp/git.mozilla.org/gecko-dev$ grep -rE "[-+,:?]\s*$" --include=*.js browser | wc
  85037  377303 7788389
/tmp/git.mozilla.org/gecko-dev$

I suggest to update the coding style guide to better agree with current practice.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

A bug is not the appropriate venue for such a suggestion, you should bring it up to the dev-platform or firefox-dev mailing lists. It certainly isn't something specific to devtools. At the sametime you should keep in mind that the style guide is not a rigid set of rules, and different modules (and module owners) often have slightly different opinions.