Closed Bug 1037447 Opened 5 years ago Closed 5 years ago

Introduce nsICacheEntry nsICacheStorage.openTruncate(URL, idEnhance)

Categories

(Core :: Networking: Cache, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: mayhemer, Assigned: mayhemer)

Details

Attachments

(1 file)

It may simplify some code that always creates a new entry and would need an intermediate callback helper class.
Attached patch v1Splinter Review
Attachment #8454464 - Flags: review?(michal.novotny)
Comment on attachment 8454464 [details] [diff] [review]
v1

Review of attachment 8454464 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/cache2/nsICacheStorage.idl
@@ +78,5 @@
>                      in uint32_t aFlags,
>                      in nsICacheEntryOpenCallback aCallback);
>  
>    /**
> +   * Immediate opens a new and empty cache entry in the storage, any existing

Immediately ?

::: netwerk/test/unit/xpcshell.ini
@@ +24,5 @@
>  [test_cache2-01a-basic-readonly.js]
>  [test_cache2-01b-basic-datasize.js]
>  [test_cache2-01c-basic-hasmeta-only.js]
>  [test_cache2-01d-basic-not-wanted.js]
> +[test_cache2-01f-basic-openTruncate.js]

Please, move it down so they are alphabetically ordered.
Attachment #8454464 - Flags: review?(michal.novotny) → review+
https://hg.mozilla.org/mozilla-central/rev/72a245d3e415
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.