1037447 - Introduce nsICacheEntry nsICacheStorage.openTruncate(URL, idEnhance)

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Honza Bambas (:mayhemer)]

It may simplify some code that always creates a new entry and would need an intermediate callback helper class.

Comment 1

[Honza Bambas (:mayhemer)]

Attachment: v1

Comment 2

[Michal Novotny [:michal]]

Comment on attachment 8454464 [details] [diff] [review]
v1

Review of attachment 8454464 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/cache2/nsICacheStorage.idl
@@ +78,5 @@
>                      in uint32_t aFlags,
>                      in nsICacheEntryOpenCallback aCallback);
>  
>    /**
> +   * Immediate opens a new and empty cache entry in the storage, any existing

Immediately ?

::: netwerk/test/unit/xpcshell.ini
@@ +24,5 @@
>  [test_cache2-01a-basic-readonly.js]
>  [test_cache2-01b-basic-datasize.js]
>  [test_cache2-01c-basic-hasmeta-only.js]
>  [test_cache2-01d-basic-not-wanted.js]
> +[test_cache2-01f-basic-openTruncate.js]

Please, move it down so they are alphabetically ordered.

Comment 3

[Honza Bambas (:mayhemer)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/72a245d3e415
https://tbpl.mozilla.org/?tree=Try&rev=5e31fde76c91

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/72a245d3e415