Don't package test data in GaiaTest for PyPI

RESOLVED FIXED

Status

Firefox OS
Gaia::UI Tests
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jgraham, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Many parts of GaiaTest are very reusable for multiple projects working with the Gaia UI. However it is entirely unnecessary for any of these consumers to get the Gaia UI tests themselves. AIUI the UI tests are run directly from Git, so there is no need for them to be packaged with the python code for that reason.
(Reporter)

Comment 1

4 years ago
diff --git a/tests/python/gaia-ui-tests/MANIFEST.in b/tests/python/gaia-ui-tests/MANIFEST.in
index e95b4a1..13b54a8 100644
--- a/tests/python/gaia-ui-tests/MANIFEST.in
+++ b/tests/python/gaia-ui-tests/MANIFEST.in
@@ -1,4 +1,4 @@
-recursive-include gaiatest/atoms *.js
-recursive-include gaiatest/resources *.*
 exclude MANIFEST.in
 include requirements.txt
+exclude gaiatest/tests
+exclude gaiatest/resources/*


I'm not sure this is the right change (in particular I'm not sure about resources/; there seem to be a couple of places that assume it exists, but I don't know how important they are outside of the Gaia UI Test context), but it leaves me with a 73 kB package rather than a 2.7Mb one.

Comment 2

4 years ago
The one place I can see where resources is used is within GaiaTestCase which is a test specific class (mostly) so I think it's fine to package without the resources folder.
(Reporter)

Comment 3

4 years ago
Created attachment 8457949 [details] [review]
Don't package test data or resources in zip file
Attachment #8457949 - Flags: review?(zcampbell)

Comment 4

4 years ago
Comment on attachment 8457949 [details] [review]
Don't package test data or resources in zip file

f+ from me, but I think Dave is the man to r? this as he is the main man for gaiatest releases.
Attachment #8457949 - Flags: review?(zcampbell)
Attachment #8457949 - Flags: review?(dave.hunt)
Attachment #8457949 - Flags: feedback+
Comment on attachment 8457949 [details] [review]
Don't package test data or resources in zip file

We provide a helper for accessing the resources from tests, and although this won't break our tests, it's possible users of gaiatest are currently dependent on these resources. The removal of the atoms almost certainly be a problem though.
Attachment #8457949 - Flags: review?(dave.hunt) → review-
(Reporter)

Updated

4 years ago
Attachment #8457949 - Flags: review- → review?(dave.hunt)
Comment on attachment 8457949 [details] [review]
Don't package test data or resources in zip file

Landed in:
https://github.com/mozilla-b2g/gaia/commit/7fbcfbacf286c2a8e41a3a96b6d82f1541880617
Attachment #8457949 - Flags: review?(dave.hunt) → review+
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.