Closed
Bug 1037470
Opened 9 years ago
Closed 9 years ago
Fails to build in debug mode with disabled JIT
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: stransky, Assigned: stransky)
Details
Attachments
(1 file)
1.10 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
Js engine fails to build in debug mode with disabled ION.
Comment 1•9 years ago
|
||
Is this bug 1037252?
Assignee | ||
Comment 2•9 years ago
|
||
Igor, can you check this one? Thanks!
Attachment #8454466 -
Flags: review?(igor)
Assignee | ||
Comment 3•9 years ago
|
||
No, this one is different - fails only in the Debugger.cpp and it's caused by #ifdef JS_ION in RematerializedFrame.h. RematerializedFrame class is not defined when ion is disabled but it's still used in the debugger.
Comment 4•9 years ago
|
||
Comment on attachment 8454466 [details] [diff] [review] patch Review of attachment 8454466 [details] [diff] [review]: ----------------------------------------------------------------- Igor left the project years ago so I'll r+ this patch.
Attachment #8454466 -
Flags: review?(igor) → review+
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8454466 [details] [diff] [review] patch Thanks! Try build https://tbpl.mozilla.org/?tree=Try&rev=4244a064da2b
Comment 6•9 years ago
|
||
(Just for future reference, a full "-b do -p all -u all" Try build for a trivial patch that should have no effect on our official builds is usually frowned upon. During the weekend it's less of an issue, but on other days there can be significant backlog/delays on Try.)
Comment 8•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/46229cdd48f4
Assignee: nobody → stransky
Keywords: checkin-needed
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/46229cdd48f4
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•