1037470 - Fails to build in debug mode with disabled JIT

Status: RESOLVED FIXED

Description

[Martin Stránský [:stransky] (Back on Aug 19)]

Js engine fails to build in debug mode with disabled ION.

Comment 1

[Jan de Mooij [:jandem]]

Is this bug 1037252?

Comment 2

[Martin Stránský [:stransky] (Back on Aug 19)]

Attachment: patch

Igor, can you check this one? Thanks!

Comment 3

[Martin Stránský [:stransky] (Back on Aug 19)]

No, this one is different - fails only in the Debugger.cpp and it's caused by #ifdef JS_ION in RematerializedFrame.h.

RematerializedFrame class is not defined when ion is disabled but it's still used in the debugger.

Comment 4

[Jan de Mooij [:jandem]]

Comment on attachment 8454466 [details] [diff] [review]
patch

Review of attachment 8454466 [details] [diff] [review]:
-----------------------------------------------------------------

Igor left the project years ago so I'll r+ this patch.

Comment 5

[Martin Stránský [:stransky] (Back on Aug 19)]

Comment on attachment 8454466 [details] [diff] [review]
patch

Thanks! Try build https://tbpl.mozilla.org/?tree=Try&rev=4244a064da2b

Comment 6

[Jan de Mooij [:jandem]]

(Just for future reference, a full "-b do -p all -u all" Try build for a trivial patch that should have no effect on our official builds is usually frowned upon. During the weekend it's less of an issue, but on other days there can be significant backlog/delays on Try.)

Comment 7

[Martin Stránský [:stransky] (Back on Aug 19)]

Okay, thanks.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/46229cdd48f4

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/46229cdd48f4