1037474 - 2.x simulators don't work with Firefox 31 or earlier

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Simulator, defect)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

Even though I have every simulator installed, Firefox 30 only shows the 1.x ones. This is what I see in the log:

console.log: [e-mail]: init
console.debug: [e-mail]
  ADB: 
  Asking for host:version
console.debug: [e-mail]
  ADB: 
  running checker onerror
console.log: [e-mail]: Didn't find ADB process running, restarting
console.debug: [e-mail]
  ADB: 
  running checker onclose
* daemon not running. starting it now on port 5037 *
* daemon started successfully *
console.error: fxos_2_1_simulator: 
  Error opening input stream (invalid filename?)
console.error: fxos_2_1_simulator: 
  Error opening input stream (invalid filename?)
console.error: fxos_2_0_simulator: 
  Error opening input stream (invalid filename?)
console.error: fxos_2_0_simulator: 
  Error opening input stream (invalid filename?)

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

The issue is that the 2.x simulators have been built with m-c's XPI generator, which no longer adds the file "defaults/preferences/prefs.js" to the addons it makes.  I guess this is generally not how you're "supposed" to use the SDK, since we should be using the tools for release channel I guess, but that's a bit trickier than just calling the ones in-tree (maybe :ochameau was too optimistic here...).

The addon runner (sdk/addon/runner.js) in Firefox 31 and earlier expects all addons to contain this file, so it becomes upset that it is missing and addon loading dies.

:zombie, I noticed it was your commit to addon-sdk[1] that removed the creation of the "prefs.js" file.  Do you have any suggestions on the best fix here?

As I see it, possible fixes are:

1. Add-on SDK could keep making this file until Firefox 32 is in release channel
2. Firefox 30 and 31 could be updated to not explode when the file is missing
3. For our simulator build process, we could add an empty "prefs.js" file
4. We could figure out how to build with release channel's cfx from m-c (sounds hard!)

[1]: https://github.com/mozilla/addon-sdk/commit/c4639882463ec5181229d2c157a65c5cd22796f3#diff-14

Comment 2

[Tomislav Jovanovic :zombie]

afaik, the general policy for jetpack is to make sure addons packed with latest released SDK version run in the release version of firefox, and our master branch from github (or m-c modulo a week) is only tested with nightly.

i worked pretty hard on that bug to make sure all the supported scenarios work (which also includes running addons packed with non-latest SDK versions in release and future firefox), so going back and supporting your scenario (using master SDK to pack addons for release fx) would probably resolved as WONTFIX by the triage team.. (not me! ;)

i suggest you use a workaround to fix this, but also be warned that other things might break with your setup in the future.. :\

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Add default prefs file to Simulator

Adds the default prefs file required for Firefox 31 and earlier.

Try: https://tbpl.mozilla.org/?tree=Try&rev=37447c415f1d

Comment 4

[Jan Keromnes [:janx]]

Comment on attachment 8455801 [details] [diff] [review]
Add default prefs file to Simulator

Review of attachment 8455801 [details] [diff] [review]:
-----------------------------------------------------------------

The fix worked for me on Linux (after I noticed that "Review" doesn't show new empty files), doesn't look dangerous and the try builds are green. Go for launch.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d6e0d60ed14a

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d6e0d60ed14a

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8455801 [details] [diff] [review]
Add default prefs file to Simulator

Approval Request Comment
[Feature/regressing bug #]: Broken by add-on SDK changes we are working around here
[User impact if declined]: FxOS 2.0 simulator add-on (which is built from the Aurora tree) won't work in Firefox Release and Beta
[Describe test coverage new/current, TBPL]: on m-c
[Risks and why]: Very low, worse case the Simulator add-on still does not work for some reason
[String/UUID change made/needed]: None

I almost landed this a=npotb, but we do indeed *build* the Simulator on TBPL, so I thought I should ask.

Comment 8

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8455801 [details] [diff] [review]
Add default prefs file to Simulator

Thanks for asking. As stated, this is simulator specific. Aurora+

Comment 9

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8455801 [details] [diff] [review]
Add default prefs file to Simulator

Approval Request Comment
[Feature/regressing bug #]: Broken by add-on SDK changes we are working around here
[User impact if declined]: FxOS 2.0 simulator add-on (which is built from the Aurora tree) won't work in Firefox Release and Beta
[Describe test coverage new/current, TBPL]: on m-c
[Risks and why]: Very low, worse case the Simulator add-on still does not work for some reason
[String/UUID change made/needed]: None

I was hopeful that this would be landed in Aurora before the merge, but that didn't happen...

Comment 10

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to J. Ryan Stinnett [:jryans] from comment #9)
> [User impact if declined]: FxOS 2.0 simulator add-on (which is built from
> the Aurora tree) won't work in Firefox Release and Beta

I meant "which is built from the Beta tree" here.  The simulator is built from the same Gecko as FxOS 2.0, so that's Gecko 32 (currently beta).

Comment 11

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8455801 [details] [diff] [review]
Add default prefs file to Simulator

Similar to bug 1038254, I meant to request approval for b2g 2.0 tree, so updating that here.

Comment 12

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

lmandel, can you take a look at this approval request?  I'd like to distribute new 2.0 simulators with this fix and the other you already approved (bug 1038254), so I'm awaiting the approval decision here.

Comment 13

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8455801 [details] [diff] [review]
Add default prefs file to Simulator

Simulator specific fix. b2g32+

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/5d399a586927

Comment 15

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I've now released Simulator builds 2.0.20140724 and 2.1.20140724 to resolve this issue.