Closed Bug 1037536 Opened 10 years ago Closed 10 years ago

Update the semiauto screen orientation test to use the latest api changes

Categories

(Firefox OS Graveyard :: Certification Suite, defect)

Product:
Firefox OS Graveyard
Component:
Certification Suite
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rwood, Assigned: askeing)

References

Details

Attachments

(1 file)

PR 236
54 bytes, text/x-github-pull-request
atsai
: review+
Details | Review 
The screen orientation api has changed to use screen.orientation.lock and screen.orientation.unlock (instead of screen.lockOrientation and screen.unlockOrientation). The semiauto screen orientation test must be updated accordingly. Thanks :ato for spotting this api change.

See https://w3c.github.io/screen-orientation/#examples
Blocks: b2g-cert-tests
No longer blocks: 1008970
Assignee: rwood → nobody
Depends on: 1131470
Assignee: nobody → fyen
Depends on: 743638
Attached file PR 236 — 

        Attachment #8573087 -
        Flags: review?(oouyang)

        Attachment #8573087 -
        Flags: review?(atsai)

    
    

    
  
Comment on attachment 8573087 [details] [review]
PR 236

r=me. good to go

        Attachment #8573087 -
        Flags: review?(atsai) → review+

    
    

    
  
merged.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
  

        Attachment #8573087 -
        Flags: review?(oouyang)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: