Update the semiauto screen orientation test to use the latest api changes

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
a year ago

People

(Reporter: rwood, Assigned: askeing)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

54 bytes, text/x-github-pull-request
atsai
: review+
Details | Review | Splinter Review
(Reporter)

Description

4 years ago
The screen orientation api has changed to use screen.orientation.lock and screen.orientation.unlock (instead of screen.lockOrientation and screen.unlockOrientation). The semiauto screen orientation test must be updated accordingly. Thanks :ato for spotting this api change.

See https://w3c.github.io/screen-orientation/#examples
Blocks: 970615
No longer blocks: 1008970
Assignee: rwood → nobody

Updated

4 years ago
Depends on: 1131470
(Assignee)

Updated

4 years ago
Assignee: nobody → fyen
Depends on: 743638
(Assignee)

Comment 1

4 years ago
Created attachment 8573087 [details] [review]
PR 236
Attachment #8573087 - Flags: review?(oouyang)
Attachment #8573087 - Flags: review?(atsai)

Comment 2

4 years ago
Comment on attachment 8573087 [details] [review]
PR 236

r=me. good to go
Attachment #8573087 - Flags: review?(atsai) → review+

Comment 3

4 years ago
merged.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

a year ago
Attachment #8573087 - Flags: review?(oouyang)
You need to log in before you can comment on or make changes to this bug.