1037613 - rm js_GetLocalizedErrorMessage, localeGetErrorMessage callback

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

Attachment: Patch

JSLocaleCallbacks has a localeGetErrorMessage callback, but it's always null in Firefox. If we remove it, we can also remove js_GetLocalizedErrorMessage. Maybe some other embedder out there uses the localeGetErrorMessage callback but I doubt it.

Also, the error callbacks have a |const char *locale| argument, but it's always nullptr (and unused) so I removed it as well.

Comment 1

[Jason Orendorff [:jorendorff]]

Comment on attachment 8454632 [details] [diff] [review]
Patch

Review of attachment 8454632 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jscntxt.cpp
@@ +677,1 @@
>          AutoSuppressGC suppressGC(cx);

While we're in this code, do you know why we suppress GC here?

Comment 2

[Jan de Mooij [:jandem]]

(In reply to Jason Orendorff [:jorendorff] from comment #1)
> While we're in this code, do you know why we suppress GC here?

It's just a way to suppress the static analysis, it treats function pointer calls as GC calls but in practice none of these can GC. I'm pretty sure there are places where we'd need extra Rooteds if we didn't silence the analysis.

Comment 3

[Jan de Mooij [:jandem]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/43878d4b6d7f

Linux64 Try: https://tbpl.mozilla.org/?tree=Try&rev=bad4d6546f2a

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/43878d4b6d7f