1037670 - pushing data with unexpected option_collection values can cause the resultset endpoint to return no data.

Status: RESOLVED DUPLICATE of bug 1097090

(Tree Management :: Treeherder: API, defect, P3)

Description

[Cameron Dawson [:camd]]

This causes the repo to basically be unusable, because no data whatsoever will show.

We should be able to skip jobs with bad values and still show the rest.

Comment 1

[Cameron Dawson [:camd]]

on resultset.py: 175 we may use a try/catch and if the option collection hash isn't found, then add the jobs grouped in that platform to an "error" section we return with the resultsets.  This would allow the dev submitting data to look at the endpoint result and see why his jobs aren't showing.

or we could just log it.  but either way, we need to just remove the jobs.

It may just be a good idea to have a try-catch block inside each of the for loops.

Comment 3

[James Lal [:lightsofapollo]]

Going to take an initial crack at this since I keep managing to break stuff by omitting collections.

Comment 4

[James Lal [:lightsofapollo]]

Attachment: https://github.com/mozilla/treeherder-service/pull/332

bandaid patch seems like UI copes with this just fine too.

Comment 5

[Mauro Doglio [:mdoglio]]

Comment on attachment 8549966 [details] [review]
https://github.com/mozilla/treeherder-service/pull/332

I didn't forget about this, I'm just waiting for bug 1097090 to land on master to verify this is not needed :-)

Comment 6

[Mauro Doglio [:mdoglio]]

This *should* be solved on latest master

Comment 7

[Mauro Doglio [:mdoglio]]

Comment on attachment 8549966 [details] [review]
https://github.com/mozilla/treeherder-service/pull/332

Now that bug bug 1097090 is solved, we can drop the changes to treeherder/webapp/api/resultset.py
The changes to  treeherder/webapp/api/utils.py are still useful, I'm happy to merge them :-)
Can you please update/rebase your PR accordingly?