54 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
This causes the repo to basically be unusable, because no data whatsoever will show. We should be able to skip jobs with bad values and still show the rest.
on resultset.py: 175 we may use a try/catch and if the option collection hash isn't found, then add the jobs grouped in that platform to an "error" section we return with the resultsets. This would allow the dev submitting data to look at the endpoint result and see why his jobs aren't showing. or we could just log it. but either way, we need to just remove the jobs. It may just be a good idea to have a try-catch block inside each of the for loops.
4 years ago
4 years ago
No longer blocks: 1030636
Priority: P1 → P2
Hardware: x86 → All
No longer blocks: 1072676
Component: Treeherder → Treeherder: API
Going to take an initial crack at this since I keep managing to break stuff by omitting collections.
Assignee: nobody → jlal
Created attachment 8549966 [details] [review] https://github.com/mozilla/treeherder-service/pull/332 bandaid patch seems like UI copes with this just fine too.
Comment on attachment 8549966 [details] [review] https://github.com/mozilla/treeherder-service/pull/332 I didn't forget about this, I'm just waiting for bug 1097090 to land on master to verify this is not needed :-)
This *should* be solved on latest master
Priority: P2 → P3
Comment on attachment 8549966 [details] [review] https://github.com/mozilla/treeherder-service/pull/332 Now that bug bug 1097090 is solved, we can drop the changes to treeherder/webapp/api/resultset.py The changes to treeherder/webapp/api/utils.py are still useful, I'm happy to merge them :-) Can you please update/rebase your PR accordingly?
Status: NEW → ASSIGNED
Assignee: jlal → nobody
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1097090
You need to log in before you can comment on or make changes to this bug.